hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 19:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Taus <tausbn@github.com>
This commit is contained in:
yoff
2023-10-31 14:12:24 +01:00
committed by GitHub
parent 1f8a51cffe
commit f76cde36bb
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
View File

@@ -393,12 +393,12 @@ module StepRelationTransformations {
* Consider a read from a global variable `x = foo`. At import time there should be a local flow step from `foo` to `x`, * Consider a read from a global variable `x = foo`. At import time there should be a local flow step from `foo` to `x`,
* while at runtime there should be a jump step from the module variable corresponding to `foo` to `x`. * while at runtime there should be a jump step from the module variable corresponding to `foo` to `x`.
* *
* Similarly for, a write `foo = y`, at import time, there is a local flow step from `y` to `foo` while at runtime there * Similarly, for a write `foo = y`, at import time, there is a local flow step from `y` to `foo` while at runtime there
* is a jump step from `y` to the module variable corresponding to `foo`. * is a jump step from `y` to the module variable corresponding to `foo`.
* *
* We need a way of distinguishing if we are looking at import time or runtime. We have the following helpful facts: * We need a way of distinguishing if we are looking at import time or runtime. We have the following helpful facts:
* - All top-level executable statements are import time (and import time only) * - All top-level executable statements are import time (and import time only)
* - All -non-top-level code may be executed at runtime (but could also be executed at import time) * - All non-top-level code may be executed at runtime (but could also be executed at import time)
* *
* We could write an analysis to determine which functions are called at import time, but until we have that, we will go * We could write an analysis to determine which functions are called at import time, but until we have that, we will go
* with the heuristic that global variables act according to import time rules at top-level program points and according * with the heuristic that global variables act according to import time rules at top-level program points and according
@@ -409,7 +409,7 @@ module StepRelationTransformations {
* Holds if `node` is found at the top level of a module. * Holds if `node` is found at the top level of a module.
*/ */
pragma[inline] pragma[inline]
predicate isTopLevel(Node node) { node.getScope() instanceof Module } private predicate isTopLevel(Node node) { node.getScope() instanceof Module }
/** Holds if a step can be taken from `nodeFrom` to `nodeTo` at import time. */ /** Holds if a step can be taken from `nodeFrom` to `nodeTo` at import time. */
predicate importTimeStep(Node nodeFrom, Node nodeTo) { predicate importTimeStep(Node nodeFrom, Node nodeTo) {