hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

CPP: Speed up nullCheckAssert in InconsistentCheckReturnNull.ql.

Browse Source
This commit is contained in:
Geoffrey White
2019-12-13 15:46:15 +00:00
parent f1f69ef85d
commit f6f7df4e8f
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/src/Likely Bugs/InconsistentCheckReturnNull.ql
View File

@@ -25,10 +25,14 @@ predicate assertInvocation(File f, int line) {
)
}
predicate nullCheckAssert(Expr e, Variable v, Declaration qualifier) {
nullCheckInCondition(e, v, qualifier) and
class InterestingExpr extends Expr {
InterestingExpr() { nullCheckInCondition(this, _, _) }
}
predicate nullCheckAssert(InterestingExpr e, Variable v, Declaration qualifier) {
exists(File f, int i |
e.getLocation().getStartLine() = i and e.getFile() = f and assertInvocation(f, i)
e.getLocation().getStartLine() = i and e.getFile() = f and assertInvocation(f, i) and
nullCheckInCondition(e, v, qualifier)
)
}