hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

remove redundant check

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-06-11 12:18:41 +02:00
parent 1124816f73
commit f634c62af5
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/src/Security/CWE-327/BadRandomness.ql
View File

@@ -117,11 +117,7 @@ private DataFlow::Node goodRandom(DataFlow::TypeTracker t, DataFlow::SourceNode
not exists(BinaryExpr binop | binop = result.asExpr() |
binop.getOperator().regexpMatch(".*(<|>).*")
or
binop.getOperator() = "*" and
(
isPowerOfTwo().asExpr() = binop.getAnOperand() or
binop.getAnOperand().(NumberLiteral).getValue().regexpMatch("0x0*10*")
)
binop.getOperator() = "*" and isPowerOfTwo().asExpr() = binop.getAnOperand()
or
binop.getOperator() = "+" and exists(binop.getAnOperand().getStringValue()) // string concat does not produce a number
)