diff --git a/python/ql/lib/change-notes/2023-06-13-container-store-steps.md b/python/ql/lib/change-notes/2023-06-13-container-store-steps.md new file mode 100644 index 00000000000..3e12554a92b --- /dev/null +++ b/python/ql/lib/change-notes/2023-06-13-container-store-steps.md @@ -0,0 +1,4 @@ +--- +category: minorAnalysis +--- +* More precise modelling of several container functions (such as `sorted`, `reversed`) and methods (such as `set.add`, `list.append`). diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/TaintTrackingPrivate.qll b/python/ql/lib/semmle/python/dataflow/new/internal/TaintTrackingPrivate.qll index dac2ff0232e..3a23f790a44 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/TaintTrackingPrivate.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/TaintTrackingPrivate.qll @@ -185,25 +185,6 @@ predicate containerStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) { // longer -- but there needs to be a matching read-step for the store-step, and we // don't provide that right now. DataFlowPrivate::comprehensionStoreStep(nodeFrom, _, nodeTo) - or - // functions operating on collections - exists(DataFlow::CallCfgNode call | call = nodeTo | - call = API::builtin(["sorted", "reversed", "iter", "next"]).getACall() and - call.getArg(0) = nodeFrom - ) - or - // dict methods - exists(DataFlow::MethodCallNode call, string methodName | call = nodeTo | - methodName in ["values", "items"] and - call.calls(nodeFrom, methodName) - ) - or - // list.append, set.add - exists(DataFlow::MethodCallNode call, DataFlow::Node obj | - call.calls(obj, ["append", "add"]) and - obj = nodeTo.(DataFlow::PostUpdateNode).getPreUpdateNode() and - call.getArg(0) = nodeFrom - ) } /** diff --git a/python/ql/lib/semmle/python/frameworks/Stdlib.qll b/python/ql/lib/semmle/python/frameworks/Stdlib.qll index bfd9144020d..ec8d808d9ea 100644 --- a/python/ql/lib/semmle/python/frameworks/Stdlib.qll +++ b/python/ql/lib/semmle/python/frameworks/Stdlib.qll @@ -3883,6 +3883,9 @@ private module StdlibPrivate { } } + // --------------------------------------------------------------------------- + // Flow summaries for functions operating on containers + // --------------------------------------------------------------------------- /** A flow summary for `reversed`. */ class ReversedSummary extends SummarizedCallable { ReversedSummary() { this = "builtins.reversed" } @@ -3894,9 +3897,114 @@ private module StdlibPrivate { } override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { - input = "Argument[0].ListElement" and + ( + input = "Argument[0].ListElement" + or + input = "Argument[0].SetElement" + or + exists(DataFlow::TupleElementContent tc, int i | i = tc.getIndex() | + input = "Argument[0].TupleElement[" + i.toString() + "]" + ) + // TODO: Once we have DictKeyContent, we need to transform that into ListElementContent + ) and output = "ReturnValue.ListElement" and preservesValue = true + or + input = "Argument[0]" and + output = "ReturnValue" and + preservesValue = false + } + } + + /** A flow summary for `sorted`. */ + class SortedSummary extends SummarizedCallable { + SortedSummary() { this = "builtins.sorted" } + + override DataFlow::CallCfgNode getACall() { result = API::builtin("sorted").getACall() } + + override DataFlow::ArgumentNode getACallback() { + result = API::builtin("sorted").getAValueReachableFromSource() + } + + override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { + exists(string content | + content = "ListElement" + or + content = "SetElement" + or + exists(DataFlow::TupleElementContent tc, int i | i = tc.getIndex() | + content = "TupleElement[" + i.toString() + "]" + ) + | + // TODO: Once we have DictKeyContent, we need to transform that into ListElementContent + input = "Argument[0]." + content and + output = "ReturnValue.ListElement" and + preservesValue = true + ) + or + input = "Argument[0]" and + output = "ReturnValue" and + preservesValue = false + } + } + + /** A flow summary for `iter`. */ + class IterSummary extends SummarizedCallable { + IterSummary() { this = "builtins.iter" } + + override DataFlow::CallCfgNode getACall() { result = API::builtin("iter").getACall() } + + override DataFlow::ArgumentNode getACallback() { + result = API::builtin("iter").getAValueReachableFromSource() + } + + override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { + ( + input = "Argument[0].ListElement" + or + input = "Argument[0].SetElement" + or + exists(DataFlow::TupleElementContent tc, int i | i = tc.getIndex() | + input = "Argument[0].TupleElement[" + i.toString() + "]" + ) + // TODO: Once we have DictKeyContent, we need to transform that into ListElementContent + ) and + output = "ReturnValue.ListElement" and + preservesValue = true + or + input = "Argument[0]" and + output = "ReturnValue" and + preservesValue = false + } + } + + /** A flow summary for `next`. */ + class NextSummary extends SummarizedCallable { + NextSummary() { this = "builtins.next" } + + override DataFlow::CallCfgNode getACall() { result = API::builtin("next").getACall() } + + override DataFlow::ArgumentNode getACallback() { + result = API::builtin("next").getAValueReachableFromSource() + } + + override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { + ( + input = "Argument[0].ListElement" + or + input = "Argument[0].SetElement" + or + exists(DataFlow::TupleElementContent tc, int i | i = tc.getIndex() | + input = "Argument[0].TupleElement[" + i.toString() + "]" + ) + // TODO: Once we have DictKeyContent, we need to transform that into ListElementContent + ) and + output = "ReturnValue" and + preservesValue = true + or + input = "Argument[1]" and + output = "ReturnValue" and + preservesValue = true } } @@ -4127,6 +4235,143 @@ private module StdlibPrivate { preservesValue = true } } + + /** + * A flow summary for `dict.values`. + * + * See https://docs.python.org/3.10/library/stdtypes.html#dict.values + */ + class DictValues extends SummarizedCallable { + DictValues() { this = "dict.values" } + + override DataFlow::CallCfgNode getACall() { + result.(DataFlow::MethodCallNode).calls(_, "values") + } + + override DataFlow::ArgumentNode getACallback() { + result.(DataFlow::AttrRead).getAttributeName() = "values" + } + + override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { + exists(DataFlow::DictionaryElementContent dc, string key | key = dc.getKey() | + input = "Argument[self].DictionaryElement[" + key + "]" and + output = "ReturnValue.ListElement" and + preservesValue = true + ) + or + input = "Argument[self]" and + output = "ReturnValue" and + preservesValue = false + } + } + + /** + * A flow summary for `dict.keys`. + * + * See https://docs.python.org/3.10/library/stdtypes.html#dict.keys + */ + class DictKeys extends SummarizedCallable { + DictKeys() { this = "dict.keys" } + + override DataFlow::CallCfgNode getACall() { result.(DataFlow::MethodCallNode).calls(_, "keys") } + + override DataFlow::ArgumentNode getACallback() { + result.(DataFlow::AttrRead).getAttributeName() = "keys" + } + + override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { + // TODO: Once we have DictKeyContent, we need to transform that into ListElementContent + input = "Argument[self]" and + output = "ReturnValue" and + preservesValue = false + } + } + + /** + * A flow summary for `dict.items`. + * + * See https://docs.python.org/3.10/library/stdtypes.html#dict.items + */ + class DictItems extends SummarizedCallable { + DictItems() { this = "dict.items" } + + override DataFlow::CallCfgNode getACall() { + result.(DataFlow::MethodCallNode).calls(_, "items") + } + + override DataFlow::ArgumentNode getACallback() { + result.(DataFlow::AttrRead).getAttributeName() = "items" + } + + override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { + exists(DataFlow::DictionaryElementContent dc, string key | key = dc.getKey() | + input = "Argument[self].DictionaryElement[" + key + "]" and + output = "ReturnValue.ListElement.TupleElement[1]" and + preservesValue = true + ) + or + // TODO: Add the keys to output list + input = "Argument[self]" and + output = "ReturnValue" and + preservesValue = false + } + } + + /** + * A flow summary for `list.append`. + * + * See https://docs.python.org/3.10/library/stdtypes.html#typesseq-mutable + */ + class ListAppend extends SummarizedCallable { + ListAppend() { this = "list.append" } + + override DataFlow::CallCfgNode getACall() { + result.(DataFlow::MethodCallNode).calls(_, "append") + } + + override DataFlow::ArgumentNode getACallback() { + result.(DataFlow::AttrRead).getAttributeName() = "append" + } + + override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { + // newly added element added to this + input = "Argument[0]" and + output = "Argument[self].ListElement" and + preservesValue = true + or + // transfer taint from new element to this (TODO: remove in future when taint-handling is more in line with other languages) + input = "Argument[0]" and + output = "Argument[self]" and + preservesValue = false + } + } + + /** + * A flow summary for `set.add`. + * + * See https://docs.python.org/3.10/library/stdtypes.html#frozenset.add + */ + class SetAdd extends SummarizedCallable { + SetAdd() { this = "set.add" } + + override DataFlow::CallCfgNode getACall() { result.(DataFlow::MethodCallNode).calls(_, "add") } + + override DataFlow::ArgumentNode getACallback() { + result.(DataFlow::AttrRead).getAttributeName() = "add" + } + + override predicate propagatesFlowExt(string input, string output, boolean preservesValue) { + // newly added element added to this + input = "Argument[0]" and + output = "Argument[self].SetElement" and + preservesValue = true + or + // transfer taint from new element to this (TODO: remove in future when taint-handling is more in line with other languages) + input = "Argument[0]" and + output = "Argument[self]" and + preservesValue = false + } + } } // --------------------------------------------------------------------------- diff --git a/python/ql/test/experimental/dataflow/coverage/test.py b/python/ql/test/experimental/dataflow/coverage/test.py index f35339e4dca..81623c58ea0 100644 --- a/python/ql/test/experimental/dataflow/coverage/test.py +++ b/python/ql/test/experimental/dataflow/coverage/test.py @@ -192,7 +192,7 @@ def test_nested_comprehension_deep_with_local_flow(): def test_nested_comprehension_dict(): d = {"s": [SOURCE]} x = [y for k, v in d.items() for y in v] - SINK(x[0]) #$ MISSING:flow="SOURCE, l:-2 -> x[0]" + SINK(x[0]) #$ flow="SOURCE, l:-2 -> x[0]" def test_nested_comprehension_paren(): diff --git a/python/ql/test/experimental/dataflow/coverage/test_builtins.py b/python/ql/test/experimental/dataflow/coverage/test_builtins.py index 629e2600280..24592337076 100644 --- a/python/ql/test/experimental/dataflow/coverage/test_builtins.py +++ b/python/ql/test/experimental/dataflow/coverage/test_builtins.py @@ -171,7 +171,7 @@ def test_list_copy(): def test_list_append(): l = [NONSOURCE] l.append(SOURCE) - SINK(l[1]) #$ MISSING: flow="SOURCE, l:-1 -> l[1]" + SINK(l[1]) #$ flow="SOURCE, l:-1 -> l[1]" ### Set @@ -188,7 +188,7 @@ def test_set_copy(): def test_set_add(): s = set([]) s.add(SOURCE) - SINK(s.pop()) #$ MISSING: flow="SOURCE, l:-2 -> s.pop()" + SINK(s.pop()) #$ flow="SOURCE, l:-1 -> s.pop()" ### Dict @@ -202,7 +202,7 @@ def test_dict_values(): d = {'k': SOURCE} vals = d.values() val_list = list(vals) - SINK(val_list[0]) #$ MISSING: flow="SOURCE, l:-3 -> val_list[0]" + SINK(val_list[0]) #$ flow="SOURCE, l:-3 -> val_list[0]" @expects(4) def test_dict_items(): @@ -210,9 +210,9 @@ def test_dict_items(): items = d.items() item_list = list(items) SINK_F(item_list[0][0]) # expecting FP due to imprecise flow - SINK(item_list[0][1]) #$ MISSING: flow="SOURCE, l:-4 -> item_list[0][1]" + SINK(item_list[0][1]) #$ flow="SOURCE, l:-4 -> item_list[0][1]" SINK(item_list[1][0]) #$ MISSING: flow="SOURCE, l:-5 -> item_list[1][0]" - SINK_F(item_list[1][1]) # expecting FP due to imprecise flow + SINK_F(item_list[1][1]) #$ SPURIOUS: flow="SOURCE, l:-6 -> item_list[1][1]" @expects(3) def test_dict_pop(): @@ -257,17 +257,17 @@ def test_dict_copy(): def test_sorted_list(): l0 = [SOURCE] l = sorted(l0) - SINK(l[0]) #$ MISSING: flow="SOURCE, l:-2 -> l[0]" + SINK(l[0]) #$ flow="SOURCE, l:-2 -> l[0]" def test_sorted_tuple(): t = (SOURCE,) l = sorted(t) - SINK(l[0]) #$ MISSING: flow="SOURCE, l:-2 -> l[0]" + SINK(l[0]) #$ flow="SOURCE, l:-2 -> l[0]" def test_sorted_set(): s = {SOURCE} l = sorted(s) - SINK(l[0]) #$ MISSING: flow="SOURCE, l:-2 -> l[0]" + SINK(l[0]) #$ flow="SOURCE, l:-2 -> l[0]" def test_sorted_dict(): d = {SOURCE: "val"} @@ -289,8 +289,8 @@ def test_reversed_tuple(): t = (SOURCE, NONSOURCE) r = reversed(t) l = list(r) - SINK_F(l[0]) - SINK(l[1]) #$ MISSING: flow="SOURCE, l:-4 -> l[1]" + SINK_F(l[0]) #$ SPURIOUS: flow="SOURCE, l:-3 -> l[0]" + SINK(l[1]) #$ flow="SOURCE, l:-4 -> l[1]" @expects(2) def test_reversed_dict(): @@ -306,19 +306,19 @@ def test_iter_list(): l0 = [SOURCE] i = iter(l0) l = list(i) - SINK(l[0]) #$ MISSING: flow="SOURCE, l:-3 -> l[0]" + SINK(l[0]) #$ flow="SOURCE, l:-3 -> l[0]" def test_iter_tuple(): t = (SOURCE,) i = iter(t) l = list(i) - SINK(l[0]) #$ MISSING: flow="SOURCE, l:-3 -> l[0]" + SINK(l[0]) #$ flow="SOURCE, l:-3 -> l[0]" def test_iter_set(): t = {SOURCE} i = iter(t) l = list(i) - SINK(l[0]) #$ MISSING: flow="SOURCE, l:-3 -> l[0]" + SINK(l[0]) #$ flow="SOURCE, l:-3 -> l[0]" def test_iter_dict(): d = {SOURCE: "val"} @@ -331,7 +331,7 @@ def test_iter_iter(): l0 = [SOURCE] i = iter(iter(l0)) l = list(i) - SINK(l[0]) #$ MISSING: flow="SOURCE, l:-3 -> l[0]" + SINK(l[0]) #$ flow="SOURCE, l:-3 -> l[0]" ### next @@ -339,19 +339,19 @@ def test_next_list(): l = [SOURCE] i = iter(l) n = next(i) - SINK(n) #$ MISSING: flow="SOURCE, l:-3 -> n" + SINK(n) #$ flow="SOURCE, l:-3 -> n" def test_next_tuple(): t = (SOURCE,) i = iter(t) n = next(i) - SINK(n) #$ MISSING: flow="SOURCE, l:-3 -> n" + SINK(n) #$ flow="SOURCE, l:-3 -> n" def test_next_set(): s = {SOURCE} i = iter(s) n = next(i) - SINK(n) #$ MISSING: flow="SOURCE, l:-3 -> n" + SINK(n) #$ flow="SOURCE, l:-3 -> n" def test_next_dict(): d = {SOURCE: "val"} diff --git a/python/ql/test/experimental/dataflow/summaries/summaries.expected b/python/ql/test/experimental/dataflow/summaries/summaries.expected index b566cbdedc6..1d8a9f1eb0c 100644 --- a/python/ql/test/experimental/dataflow/summaries/summaries.expected +++ b/python/ql/test/experimental/dataflow/summaries/summaries.expected @@ -3,8 +3,9 @@ edges | summaries.py:32:20:32:25 | ControlFlowNode for SOURCE | summaries.py:32:11:32:26 | ControlFlowNode for identity() | | summaries.py:36:18:36:54 | ControlFlowNode for apply_lambda() | summaries.py:37:6:37:19 | ControlFlowNode for tainted_lambda | | summaries.py:36:48:36:53 | ControlFlowNode for SOURCE | summaries.py:36:18:36:54 | ControlFlowNode for apply_lambda() | +| summaries.py:44:16:44:33 | ControlFlowNode for reversed() | summaries.py:45:6:45:20 | ControlFlowNode for Subscript | | summaries.py:44:16:44:33 | ControlFlowNode for reversed() [List element] | summaries.py:45:6:45:17 | ControlFlowNode for tainted_list [List element] | -| summaries.py:44:25:44:32 | ControlFlowNode for List | summaries.py:45:6:45:20 | ControlFlowNode for Subscript | +| summaries.py:44:25:44:32 | ControlFlowNode for List | summaries.py:44:16:44:33 | ControlFlowNode for reversed() | | summaries.py:44:25:44:32 | ControlFlowNode for List [List element] | summaries.py:44:16:44:33 | ControlFlowNode for reversed() [List element] | | summaries.py:44:26:44:31 | ControlFlowNode for SOURCE | summaries.py:44:25:44:32 | ControlFlowNode for List | | summaries.py:44:26:44:31 | ControlFlowNode for SOURCE | summaries.py:44:25:44:32 | ControlFlowNode for List [List element] | @@ -35,6 +36,7 @@ nodes | summaries.py:36:18:36:54 | ControlFlowNode for apply_lambda() | semmle.label | ControlFlowNode for apply_lambda() | | summaries.py:36:48:36:53 | ControlFlowNode for SOURCE | semmle.label | ControlFlowNode for SOURCE | | summaries.py:37:6:37:19 | ControlFlowNode for tainted_lambda | semmle.label | ControlFlowNode for tainted_lambda | +| summaries.py:44:16:44:33 | ControlFlowNode for reversed() | semmle.label | ControlFlowNode for reversed() | | summaries.py:44:16:44:33 | ControlFlowNode for reversed() [List element] | semmle.label | ControlFlowNode for reversed() [List element] | | summaries.py:44:25:44:32 | ControlFlowNode for List | semmle.label | ControlFlowNode for List | | summaries.py:44:25:44:32 | ControlFlowNode for List [List element] | semmle.label | ControlFlowNode for List [List element] | diff --git a/python/ql/test/experimental/dataflow/tainttracking/defaultAdditionalTaintStep/test_collections.py b/python/ql/test/experimental/dataflow/tainttracking/defaultAdditionalTaintStep/test_collections.py index 50f9a613f9b..0e2aae93554 100644 --- a/python/ql/test/experimental/dataflow/tainttracking/defaultAdditionalTaintStep/test_collections.py +++ b/python/ql/test/experimental/dataflow/tainttracking/defaultAdditionalTaintStep/test_collections.py @@ -59,7 +59,7 @@ def test_access(x, y, z): sorted(tainted_list), # $ tainted reversed(tainted_list), # $ tainted iter(tainted_list), # $ tainted - next(iter(tainted_list)), # $ tainted + next(iter(tainted_list)), # $ MISSING: tainted [i for i in tainted_list], # $ tainted [tainted_list for _i in [1,2,3]], # $ MISSING: tainted ) diff --git a/python/ql/test/experimental/query-tests/Security/CWE-022-TarSlip/TarSlip.expected b/python/ql/test/experimental/query-tests/Security/CWE-022-TarSlip/TarSlip.expected index 9a5571a8033..0042b85512c 100644 --- a/python/ql/test/experimental/query-tests/Security/CWE-022-TarSlip/TarSlip.expected +++ b/python/ql/test/experimental/query-tests/Security/CWE-022-TarSlip/TarSlip.expected @@ -1,8 +1,12 @@ edges | TarSlipImprov.py:15:7:15:39 | ControlFlowNode for Attribute() | TarSlipImprov.py:17:5:17:10 | GSSA Variable member | -| TarSlipImprov.py:17:5:17:10 | GSSA Variable member | TarSlipImprov.py:22:35:22:40 | ControlFlowNode for result | +| TarSlipImprov.py:17:5:17:10 | GSSA Variable member | TarSlipImprov.py:20:19:20:24 | ControlFlowNode for member | +| TarSlipImprov.py:20:5:20:10 | [post] ControlFlowNode for result | TarSlipImprov.py:22:35:22:40 | ControlFlowNode for result | +| TarSlipImprov.py:20:19:20:24 | ControlFlowNode for member | TarSlipImprov.py:20:5:20:10 | [post] ControlFlowNode for result | | TarSlipImprov.py:26:21:26:27 | ControlFlowNode for tarfile | TarSlipImprov.py:28:9:28:14 | SSA variable member | -| TarSlipImprov.py:28:9:28:14 | SSA variable member | TarSlipImprov.py:36:12:36:17 | ControlFlowNode for result | +| TarSlipImprov.py:28:9:28:14 | SSA variable member | TarSlipImprov.py:35:23:35:28 | ControlFlowNode for member | +| TarSlipImprov.py:35:9:35:14 | [post] ControlFlowNode for result | TarSlipImprov.py:36:12:36:17 | ControlFlowNode for result | +| TarSlipImprov.py:35:23:35:28 | ControlFlowNode for member | TarSlipImprov.py:35:9:35:14 | [post] ControlFlowNode for result | | TarSlipImprov.py:38:7:38:39 | ControlFlowNode for Attribute() | TarSlipImprov.py:39:65:39:67 | ControlFlowNode for tar | | TarSlipImprov.py:39:65:39:67 | ControlFlowNode for tar | TarSlipImprov.py:26:21:26:27 | ControlFlowNode for tarfile | | TarSlipImprov.py:39:65:39:67 | ControlFlowNode for tar | TarSlipImprov.py:39:49:39:68 | ControlFlowNode for members_filter1() | @@ -27,7 +31,9 @@ edges | TarSlipImprov.py:193:6:193:31 | ControlFlowNode for Attribute() | TarSlipImprov.py:194:49:194:51 | ControlFlowNode for tar | | TarSlipImprov.py:210:6:210:43 | ControlFlowNode for Attribute() | TarSlipImprov.py:211:5:211:7 | ControlFlowNode for tar | | TarSlipImprov.py:231:6:231:38 | ControlFlowNode for Attribute() | TarSlipImprov.py:233:9:233:9 | GSSA Variable f | -| TarSlipImprov.py:233:9:233:9 | GSSA Variable f | TarSlipImprov.py:236:44:236:50 | ControlFlowNode for members | +| TarSlipImprov.py:233:9:233:9 | GSSA Variable f | TarSlipImprov.py:235:28:235:28 | ControlFlowNode for f | +| TarSlipImprov.py:235:13:235:19 | [post] ControlFlowNode for members | TarSlipImprov.py:236:44:236:50 | ControlFlowNode for members | +| TarSlipImprov.py:235:28:235:28 | ControlFlowNode for f | TarSlipImprov.py:235:13:235:19 | [post] ControlFlowNode for members | | TarSlipImprov.py:258:6:258:26 | ControlFlowNode for Attribute() | TarSlipImprov.py:259:9:259:13 | GSSA Variable entry | | TarSlipImprov.py:259:9:259:13 | GSSA Variable entry | TarSlipImprov.py:261:25:261:29 | ControlFlowNode for entry | | TarSlipImprov.py:264:6:264:38 | ControlFlowNode for Attribute() | TarSlipImprov.py:265:9:265:13 | GSSA Variable entry | @@ -41,13 +47,19 @@ edges | TarSlipImprov.py:292:7:292:39 | ControlFlowNode for Attribute() | TarSlipImprov.py:293:1:293:3 | ControlFlowNode for tar | | TarSlipImprov.py:300:6:300:51 | ControlFlowNode for Attribute() | TarSlipImprov.py:301:49:301:51 | ControlFlowNode for tar | | TarSlipImprov.py:304:7:304:39 | ControlFlowNode for Attribute() | TarSlipImprov.py:306:5:306:10 | GSSA Variable member | -| TarSlipImprov.py:306:5:306:10 | GSSA Variable member | TarSlipImprov.py:310:49:310:54 | ControlFlowNode for result | +| TarSlipImprov.py:306:5:306:10 | GSSA Variable member | TarSlipImprov.py:309:19:309:24 | ControlFlowNode for member | +| TarSlipImprov.py:309:5:309:10 | [post] ControlFlowNode for result | TarSlipImprov.py:310:49:310:54 | ControlFlowNode for result | +| TarSlipImprov.py:309:19:309:24 | ControlFlowNode for member | TarSlipImprov.py:309:5:309:10 | [post] ControlFlowNode for result | nodes | TarSlipImprov.py:15:7:15:39 | ControlFlowNode for Attribute() | semmle.label | ControlFlowNode for Attribute() | | TarSlipImprov.py:17:5:17:10 | GSSA Variable member | semmle.label | GSSA Variable member | +| TarSlipImprov.py:20:5:20:10 | [post] ControlFlowNode for result | semmle.label | [post] ControlFlowNode for result | +| TarSlipImprov.py:20:19:20:24 | ControlFlowNode for member | semmle.label | ControlFlowNode for member | | TarSlipImprov.py:22:35:22:40 | ControlFlowNode for result | semmle.label | ControlFlowNode for result | | TarSlipImprov.py:26:21:26:27 | ControlFlowNode for tarfile | semmle.label | ControlFlowNode for tarfile | | TarSlipImprov.py:28:9:28:14 | SSA variable member | semmle.label | SSA variable member | +| TarSlipImprov.py:35:9:35:14 | [post] ControlFlowNode for result | semmle.label | [post] ControlFlowNode for result | +| TarSlipImprov.py:35:23:35:28 | ControlFlowNode for member | semmle.label | ControlFlowNode for member | | TarSlipImprov.py:36:12:36:17 | ControlFlowNode for result | semmle.label | ControlFlowNode for result | | TarSlipImprov.py:38:7:38:39 | ControlFlowNode for Attribute() | semmle.label | ControlFlowNode for Attribute() | | TarSlipImprov.py:39:49:39:68 | ControlFlowNode for members_filter1() | semmle.label | ControlFlowNode for members_filter1() | @@ -88,6 +100,8 @@ nodes | TarSlipImprov.py:211:5:211:7 | ControlFlowNode for tar | semmle.label | ControlFlowNode for tar | | TarSlipImprov.py:231:6:231:38 | ControlFlowNode for Attribute() | semmle.label | ControlFlowNode for Attribute() | | TarSlipImprov.py:233:9:233:9 | GSSA Variable f | semmle.label | GSSA Variable f | +| TarSlipImprov.py:235:13:235:19 | [post] ControlFlowNode for members | semmle.label | [post] ControlFlowNode for members | +| TarSlipImprov.py:235:28:235:28 | ControlFlowNode for f | semmle.label | ControlFlowNode for f | | TarSlipImprov.py:236:44:236:50 | ControlFlowNode for members | semmle.label | ControlFlowNode for members | | TarSlipImprov.py:254:1:254:31 | ControlFlowNode for Attribute() | semmle.label | ControlFlowNode for Attribute() | | TarSlipImprov.py:258:6:258:26 | ControlFlowNode for Attribute() | semmle.label | ControlFlowNode for Attribute() | @@ -112,6 +126,8 @@ nodes | TarSlipImprov.py:301:49:301:51 | ControlFlowNode for tar | semmle.label | ControlFlowNode for tar | | TarSlipImprov.py:304:7:304:39 | ControlFlowNode for Attribute() | semmle.label | ControlFlowNode for Attribute() | | TarSlipImprov.py:306:5:306:10 | GSSA Variable member | semmle.label | GSSA Variable member | +| TarSlipImprov.py:309:5:309:10 | [post] ControlFlowNode for result | semmle.label | [post] ControlFlowNode for result | +| TarSlipImprov.py:309:19:309:24 | ControlFlowNode for member | semmle.label | ControlFlowNode for member | | TarSlipImprov.py:310:49:310:54 | ControlFlowNode for result | semmle.label | ControlFlowNode for result | | TarSlipImprov.py:316:1:316:46 | ControlFlowNode for Attribute() | semmle.label | ControlFlowNode for Attribute() | subpaths diff --git a/python/ql/test/experimental/query-tests/Security/CWE-022-UnsafeUnpacking/UnsafeUnpack.expected b/python/ql/test/experimental/query-tests/Security/CWE-022-UnsafeUnpacking/UnsafeUnpack.expected index f32d3037bbc..6813bf887db 100644 --- a/python/ql/test/experimental/query-tests/Security/CWE-022-UnsafeUnpacking/UnsafeUnpack.expected +++ b/python/ql/test/experimental/query-tests/Security/CWE-022-UnsafeUnpacking/UnsafeUnpack.expected @@ -26,7 +26,9 @@ edges | UnsafeUnpack.py:158:23:158:27 | SSA variable chunk | UnsafeUnpack.py:163:23:163:28 | SSA variable member | | UnsafeUnpack.py:158:32:158:44 | ControlFlowNode for Attribute | UnsafeUnpack.py:158:32:158:54 | ControlFlowNode for Subscript | | UnsafeUnpack.py:158:32:158:54 | ControlFlowNode for Subscript | UnsafeUnpack.py:158:23:158:27 | SSA variable chunk | -| UnsafeUnpack.py:163:23:163:28 | SSA variable member | UnsafeUnpack.py:167:67:167:72 | ControlFlowNode for result | +| UnsafeUnpack.py:163:23:163:28 | SSA variable member | UnsafeUnpack.py:166:37:166:42 | ControlFlowNode for member | +| UnsafeUnpack.py:166:23:166:28 | [post] ControlFlowNode for result | UnsafeUnpack.py:167:67:167:72 | ControlFlowNode for result | +| UnsafeUnpack.py:166:37:166:42 | ControlFlowNode for member | UnsafeUnpack.py:166:23:166:28 | [post] ControlFlowNode for result | | UnsafeUnpack.py:174:15:174:26 | ControlFlowNode for Attribute | UnsafeUnpack.py:176:1:176:34 | ControlFlowNode for Attribute() | | UnsafeUnpack.py:194:53:194:55 | ControlFlowNode for tmp | UnsafeUnpack.py:201:29:201:36 | ControlFlowNode for Attribute | nodes @@ -65,6 +67,8 @@ nodes | UnsafeUnpack.py:158:32:158:44 | ControlFlowNode for Attribute | semmle.label | ControlFlowNode for Attribute | | UnsafeUnpack.py:158:32:158:54 | ControlFlowNode for Subscript | semmle.label | ControlFlowNode for Subscript | | UnsafeUnpack.py:163:23:163:28 | SSA variable member | semmle.label | SSA variable member | +| UnsafeUnpack.py:166:23:166:28 | [post] ControlFlowNode for result | semmle.label | [post] ControlFlowNode for result | +| UnsafeUnpack.py:166:37:166:42 | ControlFlowNode for member | semmle.label | ControlFlowNode for member | | UnsafeUnpack.py:167:67:167:72 | ControlFlowNode for result | semmle.label | ControlFlowNode for result | | UnsafeUnpack.py:174:15:174:26 | ControlFlowNode for Attribute | semmle.label | ControlFlowNode for Attribute | | UnsafeUnpack.py:176:1:176:34 | ControlFlowNode for Attribute() | semmle.label | ControlFlowNode for Attribute() | diff --git a/python/ql/test/library-tests/frameworks/aiohttp/taint_test.py b/python/ql/test/library-tests/frameworks/aiohttp/taint_test.py index ec475a592ab..54da5726803 100644 --- a/python/ql/test/library-tests/frameworks/aiohttp/taint_test.py +++ b/python/ql/test/library-tests/frameworks/aiohttp/taint_test.py @@ -39,7 +39,7 @@ async def test_taint(request: web.Request): # $ requestHandler request.cookies, # $ tainted request.cookies["key"], # $ tainted request.cookies.get("key"), # $ tainted - request.cookies.keys(), # $ MISSING: tainted + request.cookies.keys(), # $ tainted request.cookies.values(), # $ tainted request.cookies.items(), # $ tainted list(request.cookies), # $ tainted diff --git a/python/ql/test/library-tests/frameworks/multidict/taint_test.py b/python/ql/test/library-tests/frameworks/multidict/taint_test.py index 8fbac79888f..77b4f00f271 100644 --- a/python/ql/test/library-tests/frameworks/multidict/taint_test.py +++ b/python/ql/test/library-tests/frameworks/multidict/taint_test.py @@ -12,7 +12,7 @@ ensure_tainted( mdp.get("key"), # $ tainted mdp.getone("key"), # $ tainted mdp.getall("key"), # $ tainted - mdp.keys(), # $ MISSING: tainted + mdp.keys(), # $ tainted mdp.values(), # $ tainted mdp.items(), # $ tainted mdp.copy(), # $ tainted @@ -32,7 +32,7 @@ ensure_tainted( ci_mdp.get("key"), # $ tainted ci_mdp.getone("key"), # $ tainted ci_mdp.getall("key"), # $ tainted - ci_mdp.keys(), # $ MISSING: tainted + ci_mdp.keys(), # $ tainted ci_mdp.values(), # $ tainted ci_mdp.items(), # $ tainted ci_mdp.copy(), # $ tainted