Merge pull request #5533 from asgerf/js/fix-query-metadata

Approved by esbena

javascript/ql/examples/queries/dataflow/EvalTaint/EvalTaint.ql

@@ -2,6 +2,7 @@
  * @name Taint-tracking to 'eval' calls
  * @description Tracks user-controlled values into 'eval' calls (special case of js/code-injection).
  * @kind problem
+ * @problem.severity error
  * @tags security
  * @id js/examples/eval-taint
  */

javascript/ql/src/Comments/FCommentedOutCode.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision high
  * @id js/lines-of-commented-out-code-in-files
  * @tags maintainability
  */

javascript/ql/src/Metrics/FCommentRatio.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn lowValues
  * @metricType file
  * @metricAggregate avg max
- * @precision very-high
  * @tags maintainability
  * @id js/comment-ratio-per-file
  */

javascript/ql/src/Metrics/FCyclomaticComplexity.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg max
- * @precision very-high
  * @tags testability
  * @id js/cyclomatic-complexity-per-file
  */

javascript/ql/src/Metrics/FFunctions.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id js/functions-per-file
  */
 

javascript/ql/src/Metrics/FLines.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id js/lines-per-file
  */
 

javascript/ql/src/Metrics/FLinesOfCode.ql

@@ -6,7 +6,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id js/lines-of-code-in-files
  * @tags maintainability
  */

javascript/ql/src/Metrics/FLinesOfComment.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn lowValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id js/lines-of-comments-in-files
  * @tags documentation
  */

javascript/ql/src/Metrics/FLinesOfDuplicatedCode.ql

@@ -7,34 +7,14 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision high
  * @id js/duplicated-lines-in-files
  * @tags testability
  *       duplicate-code
  *       non-attributable
  */
 
-import external.CodeDuplication
-
-/**
- * Holds if line `l` of file `f` should be excluded from duplicated code detection.
- *
- * Currently, only lines on which an import declaration occurs are excluded.
- */
-predicate whitelistedLineForDuplication(File f, int l) {
-  exists(ImportDeclaration i | i.getFile() = f and i.getLocation().getStartLine() = l)
-}
-
-/**
- * Holds if line `l` of file `f` belongs to a block of lines that is duplicated somewhere else.
- */
-predicate dupLine(int l, File f) {
-  exists(DuplicateBlock d | d.sourceFile() = f |
-    l in [d.sourceStartLine() .. d.sourceEndLine()] and
-    not whitelistedLineForDuplication(f, l)
-  )
-}
+import javascript
 
 from File f, int n
-where n = count(int l | dupLine(l, f))
+where none()
 select f, n order by n desc

javascript/ql/src/Metrics/FLinesOfSimilarCode.ql

@@ -8,23 +8,14 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision high
  * @id js/similar-lines-in-files
  * @tags testability
  *       duplicate-code
  *       non-attributable
  */
 
-import external.CodeDuplication
-
-/**
- * Holds if line `l` of file `f` belong to a block of lines that is similar to a block
- * of lines appearing somewhere else.
- */
-predicate simLine(int l, File f) {
-  exists(SimilarBlock d | d.sourceFile() = f | l in [d.sourceStartLine() .. d.sourceEndLine()])
-}
+import javascript
 
 from File f, int n
-where n = count(int l | simLine(l, f))
+where none()
 select f, n order by n desc

javascript/ql/src/Metrics/FNumberOfStatements.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id js/statements-per-file
  */
 

javascript/ql/src/Metrics/FNumberOfTests.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn lowValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision medium
  * @id js/test-in-files
  */
 

javascript/ql/src/Metrics/FUseOfES6.ql

@@ -6,7 +6,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id js/es20xx-features-per-file
  */
 

javascript/ql/src/Metrics/FunCyclomaticComplexity.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType callable
  * @metricAggregate avg max sum
- * @precision very-high
  * @tags testability
  * @id js/cyclomatic-complexity-per-function
  */

javascript/ql/src/Metrics/FunLinesOfCode.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType callable
  * @metricAggregate avg sum max
- * @precision very-high
  * @tags maintainability
  * @id js/lines-of-code-per-function
  */

javascript/ql/src/external/CodeDuplication.qll

@@ -1,367 +0,0 @@
-/** Provides classes for detecting duplicate or similar code. */
-
-import semmle.javascript.Files
-
-/** Gets the relative path of `file`, with backslashes replaced by forward slashes. */
-private string relativePath(File file) { result = file.getRelativePath().replaceAll("\\", "/") }
-
-/**
- * Holds if the `index`-th token of block `copy` is in file `file`, spanning
- * column `sc` of line `sl` to column `ec` of line `el`.
- *
- * For more information, see [Locations](https://help.semmle.com/QL/learn-ql/ql/locations.html).
- */
-pragma[noinline]
-private predicate tokenLocation(File file, int sl, int sc, int ec, int el, Copy copy, int index) {
-  file = copy.sourceFile() and
-  tokens(copy, index, sl, sc, ec, el)
-}
-
-/** A token block used for detection of duplicate and similar code. */
-class Copy extends @duplication_or_similarity {
-  /** Gets the index of the last token in this block. */
-  private int lastToken() { result = max(int i | tokens(this, i, _, _, _, _) | i) }
-
-  /** Gets the index of the token in this block starting at the location `loc`, if any. */
-  int tokenStartingAt(Location loc) {
-    tokenLocation(loc.getFile(), loc.getStartLine(), loc.getStartColumn(), _, _, this, result)
-  }
-
-  /** Gets the index of the token in this block ending at the location `loc`, if any. */
-  int tokenEndingAt(Location loc) {
-    tokenLocation(loc.getFile(), _, _, loc.getEndLine(), loc.getEndColumn(), this, result)
-  }
-
-  /** Gets the line on which the first token in this block starts. */
-  int sourceStartLine() { tokens(this, 0, result, _, _, _) }
-
-  /** Gets the column on which the first token in this block starts. */
-  int sourceStartColumn() { tokens(this, 0, _, result, _, _) }
-
-  /** Gets the line on which the last token in this block ends. */
-  int sourceEndLine() { tokens(this, this.lastToken(), _, _, result, _) }
-
-  /** Gets the column on which the last token in this block ends. */
-  int sourceEndColumn() { tokens(this, this.lastToken(), _, _, _, result) }
-
-  /** Gets the number of lines containing at least (part of) one token in this block. */
-  int sourceLines() { result = this.sourceEndLine() + 1 - this.sourceStartLine() }
-
-  /** Gets an opaque identifier for the equivalence class of this block. */
-  int getEquivalenceClass() { duplicateCode(this, _, result) or similarCode(this, _, result) }
-
-  /** Gets the source file in which this block appears. */
-  File sourceFile() {
-    exists(string name | duplicateCode(this, name, _) or similarCode(this, name, _) |
-      name.replaceAll("\\", "/") = relativePath(result)
-    )
-  }
-
-  /**
-   * Holds if this element is at the specified location.
-   * The location spans column `startcolumn` of line `startline` to
-   * column `endcolumn` of line `endline` in file `filepath`.
-   * For more information, see
-   * [Locations](https://help.semmle.com/QL/learn-ql/ql/locations.html).
-   */
-  predicate hasLocationInfo(
-    string filepath, int startline, int startcolumn, int endline, int endcolumn
-  ) {
-    sourceFile().getAbsolutePath() = filepath and
-    startline = sourceStartLine() and
-    startcolumn = sourceStartColumn() and
-    endline = sourceEndLine() and
-    endcolumn = sourceEndColumn()
-  }
-
-  /** Gets a textual representation of this element. */
-  string toString() { none() }
-
-  /**
-   * Gets a block that extends this one, that is, its first token is also
-   * covered by this block, but they are not the same block.
-   */
-  Copy extendingBlock() {
-    exists(File file, int sl, int sc, int ec, int el |
-      tokenLocation(file, sl, sc, ec, el, this, _) and
-      tokenLocation(file, sl, sc, ec, el, result, 0)
-    ) and
-    this != result
-  }
-}
-
-/**
- * Holds if there is a sequence of `SimilarBlock`s `start1, ..., end1` and another sequence
- * `start2, ..., end2` such that each block extends the previous one and corresponding blocks
- * have the same equivalence class, with `start` being the equivalence class of `start1` and
- * `start2`, and `end` the equivalence class of `end1` and `end2`.
- */
-predicate similar_extension(
-  SimilarBlock start1, SimilarBlock start2, SimilarBlock end1, SimilarBlock end2, int start, int end
-) {
-  start1.getEquivalenceClass() = start and
-  start2.getEquivalenceClass() = start and
-  end1.getEquivalenceClass() = end and
-  end2.getEquivalenceClass() = end and
-  start1 != start2 and
-  (
-    end1 = start1 and end2 = start2
-    or
-    similar_extension(start1.extendingBlock(), start2.extendingBlock(), end1, end2, _, end)
-  )
-}
-
-/**
- * Holds if there is a sequence of `DuplicateBlock`s `start1, ..., end1` and another sequence
- * `start2, ..., end2` such that each block extends the previous one and corresponding blocks
- * have the same equivalence class, with `start` being the equivalence class of `start1` and
- * `start2`, and `end` the equivalence class of `end1` and `end2`.
- */
-predicate duplicate_extension(
-  DuplicateBlock start1, DuplicateBlock start2, DuplicateBlock end1, DuplicateBlock end2, int start,
-  int end
-) {
-  start1.getEquivalenceClass() = start and
-  start2.getEquivalenceClass() = start and
-  end1.getEquivalenceClass() = end and
-  end2.getEquivalenceClass() = end and
-  start1 != start2 and
-  (
-    end1 = start1 and end2 = start2
-    or
-    duplicate_extension(start1.extendingBlock(), start2.extendingBlock(), end1, end2, _, end)
-  )
-}
-
-/** A block of duplicated code. */
-class DuplicateBlock extends Copy, @duplication {
-  override string toString() { result = "Duplicate code: " + sourceLines() + " duplicated lines." }
-}
-
-/** A block of similar code. */
-class SimilarBlock extends Copy, @similarity {
-  override string toString() {
-    result = "Similar code: " + sourceLines() + " almost duplicated lines."
-  }
-}
-
-/** Holds if statement `s` is in function or toplevel `sc`. */
-private predicate stmtInContainer(Stmt s, StmtContainer sc) {
-  s.getContainer() = sc and
-  not s instanceof BlockStmt
-}
-
-/**
- * Holds if `stmt1` and `stmt2` are duplicate statements in function or toplevel `sc1` and `sc2`,
- * respectively, where `sc1` and `sc2` are not the same.
- */
-predicate duplicateStatement(StmtContainer sc1, StmtContainer sc2, Stmt stmt1, Stmt stmt2) {
-  exists(int equivstart, int equivend, int first, int last |
-    stmtInContainer(stmt1, sc1) and
-    stmtInContainer(stmt2, sc2) and
-    duplicateCoversStatement(equivstart, equivend, first, last, stmt1) and
-    duplicateCoversStatement(equivstart, equivend, first, last, stmt2) and
-    stmt1 != stmt2 and
-    sc1 != sc2
-  )
-}
-
-/**
- * Holds if statement `stmt` is covered by a sequence of `DuplicateBlock`s, where `first`
- * is the index of the token in the first block that starts at the beginning of `stmt`,
- * while `last` is the index of the token in the last block that ends at the end of `stmt`,
- * and `equivstart` and `equivend` are the equivalence classes of the first and the last
- * block, respectively.
- */
-private predicate duplicateCoversStatement(
-  int equivstart, int equivend, int first, int last, Stmt stmt
-) {
-  exists(DuplicateBlock b1, DuplicateBlock b2, Location loc |
-    stmt.getLocation() = loc and
-    first = b1.tokenStartingAt(loc) and
-    last = b2.tokenEndingAt(loc) and
-    b1.getEquivalenceClass() = equivstart and
-    b2.getEquivalenceClass() = equivend and
-    duplicate_extension(b1, _, b2, _, equivstart, equivend)
-  )
-}
-
-/**
- * Holds if `sc1` is a function or toplevel with `total` lines, and `sc2` is a function or
- * toplevel that has `duplicate` lines in common with `sc1`.
- */
-private predicate duplicateStatements(StmtContainer sc1, StmtContainer sc2, int duplicate, int total) {
-  duplicate = strictcount(Stmt stmt | duplicateStatement(sc1, sc2, stmt, _)) and
-  total = strictcount(Stmt stmt | stmtInContainer(stmt, sc1))
-}
-
-/**
- * Holds if `sc` and `other` are functions or toplevels where `percent` is the percentage
- * of lines they have in common, which is greater than 90%.
- */
-predicate duplicateContainers(StmtContainer sc, StmtContainer other, float percent) {
-  exists(int total, int duplicate | duplicateStatements(sc, other, duplicate, total) |
-    percent = 100.0 * duplicate / total and
-    percent > 90.0
-  )
-}
-
-/**
- * Holds if `stmt1` and `stmt2` are similar statements in function or toplevel `sc1` and `sc2`,
- * respectively, where `sc1` and `sc2` are not the same.
- */
-private predicate similarStatement(StmtContainer sc1, StmtContainer sc2, Stmt stmt1, Stmt stmt2) {
-  exists(int start, int end, int first, int last |
-    stmtInContainer(stmt1, sc1) and
-    stmtInContainer(stmt2, sc2) and
-    similarCoversStatement(start, end, first, last, stmt1) and
-    similarCoversStatement(start, end, first, last, stmt2) and
-    stmt1 != stmt2 and
-    sc1 != sc2
-  )
-}
-
-/**
- * Holds if statement `stmt` is covered by a sequence of `SimilarBlock`s, where `first`
- * is the index of the token in the first block that starts at the beginning of `stmt`,
- * while `last` is the index of the token in the last block that ends at the end of `stmt`,
- * and `equivstart` and `equivend` are the equivalence classes of the first and the last
- * block, respectively.
- */
-private predicate similarCoversStatement(
-  int equivstart, int equivend, int first, int last, Stmt stmt
-) {
-  exists(SimilarBlock b1, SimilarBlock b2, Location loc |
-    stmt.getLocation() = loc and
-    first = b1.tokenStartingAt(loc) and
-    last = b2.tokenEndingAt(loc) and
-    b1.getEquivalenceClass() = equivstart and
-    b2.getEquivalenceClass() = equivend and
-    similar_extension(b1, _, b2, _, equivstart, equivend)
-  )
-}
-
-/**
- * Holds if `sc1` is a function or toplevel with `total` lines, and `sc2` is a function or
- * toplevel that has `similar` similar lines to `sc1`.
- */
-private predicate similarStatements(StmtContainer sc1, StmtContainer sc2, int similar, int total) {
-  similar = strictcount(Stmt stmt | similarStatement(sc1, sc2, stmt, _)) and
-  total = strictcount(Stmt stmt | stmtInContainer(stmt, sc1))
-}
-
-/**
- * Holds if `sc` and `other` are functions or toplevels where `percent` is the percentage
- * of similar lines between the two, which is greater than 90%.
- */
-predicate similarContainers(StmtContainer sc, StmtContainer other, float percent) {
-  exists(int total, int similar | similarStatements(sc, other, similar, total) |
-    percent = 100.0 * similar / total and
-    percent > 90.0
-  )
-}
-
-/**
- * INTERNAL: do not use.
- *
- * Holds if `line` in `f` is similar to a line somewhere else.
- */
-predicate similarLines(File f, int line) {
-  exists(SimilarBlock b | b.sourceFile() = f and line in [b.sourceStartLine() .. b.sourceEndLine()])
-}
-
-private predicate similarLinesPerEquivalenceClass(int equivClass, int lines, File f) {
-  lines =
-    strictsum(SimilarBlock b, int toSum |
-      (b.sourceFile() = f and b.getEquivalenceClass() = equivClass) and
-      toSum = b.sourceLines()
-    |
-      toSum
-    )
-}
-
-/** Holds if `coveredLines` lines of `f` are similar to lines in `otherFile`. */
-pragma[noopt]
-private predicate similarLinesCovered(File f, int coveredLines, File otherFile) {
-  exists(int numLines | numLines = f.getNumberOfLines() |
-    exists(int coveredApprox |
-      coveredApprox =
-        strictsum(int num |
-          exists(int equivClass |
-            similarLinesPerEquivalenceClass(equivClass, num, f) and
-            similarLinesPerEquivalenceClass(equivClass, num, otherFile) and
-            f != otherFile
-          )
-        ) and
-      exists(int n, int product | product = coveredApprox * 100 and n = product / numLines | n > 75)
-    ) and
-    exists(int notCovered |
-      notCovered = count(int j | j in [1 .. numLines] and not similarLines(f, j)) and
-      coveredLines = numLines - notCovered
-    )
-  )
-}
-
-/**
- * INTERNAL: do not use.
- *
- * Holds if `line` in `f` is duplicated by a line somewhere else.
- */
-predicate duplicateLines(File f, int line) {
-  exists(DuplicateBlock b |
-    b.sourceFile() = f and line in [b.sourceStartLine() .. b.sourceEndLine()]
-  )
-}
-
-private predicate duplicateLinesPerEquivalenceClass(int equivClass, int lines, File f) {
-  lines =
-    strictsum(DuplicateBlock b, int toSum |
-      (b.sourceFile() = f and b.getEquivalenceClass() = equivClass) and
-      toSum = b.sourceLines()
-    |
-      toSum
-    )
-}
-
-/** Holds if `coveredLines` lines of `f` are duplicates of lines in `otherFile`. */
-pragma[noopt]
-private predicate duplicateLinesCovered(File f, int coveredLines, File otherFile) {
-  exists(int numLines | numLines = f.getNumberOfLines() |
-    exists(int coveredApprox |
-      coveredApprox =
-        strictsum(int num |
-          exists(int equivClass |
-            duplicateLinesPerEquivalenceClass(equivClass, num, f) and
-            duplicateLinesPerEquivalenceClass(equivClass, num, otherFile) and
-            f != otherFile
-          )
-        ) and
-      exists(int n, int product | product = coveredApprox * 100 and n = product / numLines | n > 75)
-    ) and
-    exists(int notCovered |
-      notCovered = count(int j | j in [1 .. numLines] and not duplicateLines(f, j)) and
-      coveredLines = numLines - notCovered
-    )
-  )
-}
-
-/** Holds if most of `f` (`percent`%) is similar to `other`. */
-predicate similarFiles(File f, File other, int percent) {
-  exists(int covered, int total |
-    similarLinesCovered(f, covered, other) and
-    total = f.getNumberOfLines() and
-    covered * 100 / total = percent and
-    percent > 80
-  ) and
-  not duplicateFiles(f, other, _)
-}
-
-/** Holds if most of `f` (`percent`%) is duplicated by `other`. */
-predicate duplicateFiles(File f, File other, int percent) {
-  exists(int covered, int total |
-    duplicateLinesCovered(f, covered, other) and
-    total = f.getNumberOfLines() and
-    covered * 100 / total = percent and
-    percent > 70
-  )
-}

javascript/ql/src/external/DuplicateFunction.ql

@@ -16,15 +16,10 @@
  */
 
 import javascript
-import CodeDuplication
 import semmle.javascript.RestrictedLocations
 
 from Function f, Function g, float percent
-where
-  duplicateContainers(f, g, percent) and
-  f.getNumBodyStmt() > 5 and
-  not duplicateContainers(f.getEnclosingStmt().getContainer(), g.getEnclosingStmt().getContainer(),
-    _)
+where none()
 select f.(FirstLineOf),
   percent.floor() + "% of statements in " + f.describe() + " are duplicated in $@.",
   g.(FirstLineOf), g.describe()

javascript/ql/src/external/DuplicateToplevel.ql

@@ -16,12 +16,9 @@
  */
 
 import javascript
-import CodeDuplication
 import semmle.javascript.RestrictedLocations
 
 from TopLevel one, TopLevel another, float percent
-where
-  duplicateContainers(one, another, percent) and
-  one.getNumLines() > 5
+where none()
 select one.(FirstLineOf), percent.floor() + "% of statements in this script are duplicated in $@.",
   another.(FirstLineOf), "another script"

javascript/ql/src/external/SimilarFunction.ql

@@ -16,16 +16,10 @@
  */
 
 import javascript
-import CodeDuplication
 import semmle.javascript.RestrictedLocations
 
 from Function f, Function g, float percent
-where
-  similarContainers(f, g, percent) and
-  f.getNumBodyStmt() > 5 and
-  not duplicateContainers(f, g, _) and
-  not duplicateContainers(f.getEnclosingStmt().getContainer(), g.getEnclosingStmt().getContainer(),
-    _)
+where none()
 select f.(FirstLineOf),
   percent.floor() + "% of statements in " + f.describe() + " are similar to statements in $@.",
   g.(FirstLineOf), g.describe()

javascript/ql/src/external/SimilarToplevel.ql

@@ -16,14 +16,10 @@
  */
 
 import javascript
-import CodeDuplication
 import semmle.javascript.RestrictedLocations
 
 from TopLevel one, TopLevel another, float percent
-where
-  similarContainers(one, another, percent) and
-  one.getNumChildStmt() > 5 and
-  not duplicateContainers(one, another, _)
+where none()
 select one.(FirstLineOf),
   percent.floor() + "% of statements in this script are similar to statements in $@.",
   another.(FirstLineOf), "another script"

javascript/ql/src/filters/FilterFrameworks.ql

@@ -1,14 +0,0 @@
-/**
- * @name Filter out framework code
- * @description Only keep results in non-framework code
- * @kind problem
- * @problem.severity warning
- * @id js/not-framework-file-filter
- */
-
-import FilterFrameworks
-import external.DefectFilter
-
-from DefectResult defres
-where nonFrameworkFile(defres.getFile())
-select defres, defres.getMessage()

javascript/ql/src/filters/FilterFrameworks.qll

@@ -1,7 +0,0 @@
-import semmle.javascript.dependencies.FrameworkLibraries
-
-/**
- * Holds if file `f` does not contain a framework library.
- */
-pragma[nomagic]
-predicate nonFrameworkFile(File f) { not exists(FrameworkLibraryInstance fl | fl.getFile() = f) }

javascript/ql/src/filters/FilterFrameworksForMetric.ql

@@ -1,14 +0,0 @@
-/**
- * @name Filter out framework code
- * @description Only keep results in non-framework code
- * @kind treemap
- * @id js/not-framework-file-metric-filter
- * @metricType file
- */
-
-import FilterFrameworks
-import external.MetricFilter
-
-from MetricResult res
-where nonFrameworkFile(res.getFile())
-select res, res.getValue()

javascript/ql/src/filters/FilterGenerated.ql

@@ -1,15 +0,0 @@
-/**
- * @name Filter out generated files
- * @description Only keep results from files that do not look like they are minified,
- *              generated by a module bundler or by Emscripten, or contain a source
- *              mapping comment.
- * @kind problem
- * @id js/not-generated-file-filter
- */
-
-import semmle.javascript.GeneratedCode
-import external.DefectFilter
-
-from DefectResult defres
-where not isGeneratedCode(defres.getFile())
-select defres, defres.getMessage()

javascript/ql/src/filters/FilterGeneratedForMetric.ql

@@ -1,16 +0,0 @@
-/**
- * @name Filter out generated files
- * @description Only keep results from files that do not look like they are minified,
- *              generated by a module bundler or by Emscripten, or contain a source
- *              mapping comment.
- * @kind treemap
- * @id js/not-generated-file-metric-filter
- * @metricType file
- */
-
-import semmle.javascript.GeneratedCode
-import external.MetricFilter
-
-from MetricResult res
-where not isGeneratedCode(res.getFile())
-select res, res.getValue()

javascript/ql/src/filters/FilterMinified.ql

@@ -1,13 +0,0 @@
-/**
- * @name Filter out minified files
- * @description Only keep results from files that are not minified.
- * @kind problem
- * @id js/not-minified-file-filter
- */
-
-import javascript
-import external.DefectFilter
-
-from DefectResult defres
-where not defres.getFile().getATopLevel().isMinified()
-select defres, defres.getMessage()

javascript/ql/src/filters/FilterMinifiedForMetric.ql

@@ -1,14 +0,0 @@
-/**
- * @name Filter out minified files
- * @description Only keep results from files that are not minified.
- * @kind treemap
- * @id js/not-minified-file-metric-filter
- * @metricType file
- */
-
-import javascript
-import external.MetricFilter
-
-from MetricResult res
-where not res.getFile().getATopLevel().isMinified()
-select res, res.getValue()

javascript/ql/test/query-tests/external/DuplicateFunction/DuplicateFunction.expected

@@ -1,6 +0,0 @@
-| d/tst.js:1:1:1:14 | functio ... s[1];\\n} | 100% of statements in function f are duplicated in $@. | d/tst.js:12:1:12:14 | functio ... s[1];\\n} | function g |
-| d/tst.js:1:1:1:14 | functio ... s[1];\\n} | 100% of statements in function f are duplicated in $@. | d/tst.js:23:10:23:21 | functio ... s[1];\\n} | function g2 |
-| d/tst.js:12:1:12:14 | functio ... s[1];\\n} | 100% of statements in function g are duplicated in $@. | d/tst.js:1:1:1:14 | functio ... s[1];\\n} | function f |
-| d/tst.js:12:1:12:14 | functio ... s[1];\\n} | 100% of statements in function g are duplicated in $@. | d/tst.js:23:10:23:21 | functio ... s[1];\\n} | function g2 |
-| d/tst.js:23:10:23:21 | functio ... s[1];\\n} | 100% of statements in function g2 are duplicated in $@. | d/tst.js:1:1:1:14 | functio ... s[1];\\n} | function f |
-| d/tst.js:23:10:23:21 | functio ... s[1];\\n} | 100% of statements in function g2 are duplicated in $@. | d/tst.js:12:1:12:14 | functio ... s[1];\\n} | function g |

javascript/ql/test/query-tests/external/DuplicateToplevel/DuplicateToplevel.expected

@@ -1,6 +0,0 @@
-| a.js:1:1:1:1 | <toplevel> | 90% of statements in this script are duplicated in $@. | e.js:1:1:1:1 | <toplevel> | another script |
-| a.js:1:1:1:1 | <toplevel> | 100% of statements in this script are duplicated in $@. | b.js:1:1:1:1 | <toplevel> | another script |
-| b.js:1:1:1:1 | <toplevel> | 90% of statements in this script are duplicated in $@. | e.js:1:1:1:1 | <toplevel> | another script |
-| b.js:1:1:1:1 | <toplevel> | 100% of statements in this script are duplicated in $@. | a.js:1:1:1:1 | <toplevel> | another script |
-| e.js:1:1:1:1 | <toplevel> | 90% of statements in this script are duplicated in $@. | a.js:1:1:1:1 | <toplevel> | another script |
-| e.js:1:1:1:1 | <toplevel> | 90% of statements in this script are duplicated in $@. | b.js:1:1:1:1 | <toplevel> | another script |

javascript/ql/test/query-tests/external/SimilarFunction/SimilarFunction.expected

@@ -1,4 +0,0 @@
-| tst.js:1:1:1:18 | functio ...  = x;\\n} | 92% of statements in function f are similar to statements in $@. | tst.js:17:1:17:18 | functio ...  = a;\\n} | function g |
-| tst.js:1:1:1:18 | functio ...  = x;\\n} | 92% of statements in function f are similar to statements in $@. | tst.js:33:9:33:24 | functio ...  = a;\\n} | function h |
-| tst.js:17:1:17:18 | functio ...  = a;\\n} | 92% of statements in function g are similar to statements in $@. | tst.js:1:1:1:18 | functio ...  = x;\\n} | function f |
-| tst.js:33:9:33:24 | functio ...  = a;\\n} | 92% of statements in function h are similar to statements in $@. | tst.js:1:1:1:18 | functio ...  = x;\\n} | function f |

javascript/ql/test/query-tests/external/SimilarToplevel/SimilarToplevel.expected

@@ -1 +0,0 @@
-| a.js:1:1:1:7 | <toplevel> | 94% of statements in this script are similar to statements in $@. | b.js:1:1:1:7 | <toplevel> | another script |