mirror of
https://github.com/github/codeql.git
synced 2026-05-05 05:35:13 +02:00
only report clear-text cookies for sensitive cookies
This commit is contained in:
@@ -73,7 +73,11 @@ private module JsCookie {
|
||||
this.getOptionArgument(2, CookieWrites::secure()).mayHaveBooleanValue(true)
|
||||
}
|
||||
|
||||
override predicate isSensitive() { none() } // TODO: Maybe it can be sensitive?
|
||||
override predicate isSensitive() {
|
||||
HeuristicNames::nameIndicatesSensitiveData(any(string s |
|
||||
this.getArgument(0).mayHaveStringValue(s)
|
||||
), _)
|
||||
}
|
||||
|
||||
override predicate isHttpOnly() { none() } // js-cookie is browser side library and doesn't support HttpOnly
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user