C++: Initial commit of cpp/comma-before-missing-indentation

cpp/ql/src/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation.qhelp

@@ -0,0 +1,18 @@
+<!DOCTYPE qhelp PUBLIC
+  "-//Semmle//qhelp//EN"
+  "qhelp.dtd">
+<qhelp>
+
+<overview>
+<p>...</p>
+</overview>
+
+<recommendation>
+<p>...</p>
+</recommendation>
+
+<example>
+<sample src="CommaBeforeMisleadingIndentation.cpp" />
+</example>
+
+</qhelp>

cpp/ql/src/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation.ql

@@ -0,0 +1 @@
+select 1

cpp/ql/test/query-tests/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation/CommaBeforeMisleadingIndentation.expected

@@ -0,0 +1 @@
+| 1 |

cpp/ql/test/query-tests/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation/CommaBeforeMisleadingIndentation.qlref

@@ -0,0 +1 @@
+Best Practices/Likely Errors/CommaBeforeMisleadingIndentation.ql

cpp/ql/test/query-tests/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation/test.cpp

@@ -0,0 +1,19 @@
+
+void test(int i, int j, int (*foo)(int))
+{
+	if (i)
+		(void)i,	// GOOD
+		(void)j;
+
+	if (i)
+		(void)i,	// BAD
+	(void)j;
+
+	foo((i++, j++)); // GOOD
+	foo((i++,        // GOOD
+	     j++));
+	foo((i++
+	   , j++));      // GOOD
+	foo((i++,
+	j++));           // BAD (?)
+}