hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Arrays: note TODOs

Browse Source
This commit is contained in:
Chris Smowton
2021-10-27 19:02:07 +01:00
committed by Ian Lynagh
parent 2cc5f3e5b7
commit f1a3c9ca20
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/kotlin-extractor/src/main/kotlin/KotlinExtractorExtension.kt
View File

@@ -511,6 +511,10 @@ class X {
((s.isArray() || s.isNullableArray()) && s.arguments.isNotEmpty()) || s.isPrimitiveArray() -> {
// TODO: fix this, this is only a dummy implementation to let the tests pass
// TODO: Figure out what signatures should be returned
// TODO: The Java extractor describes the dimensionality of array types; here we always report 1 dimension
// TODO: The Java extractor extracts a .length field, a .clone method and a type hierarchy for arrays
// TODO: Generate a short name for array types
val elementType = useTypeOld(s.getArrayElementType(pluginContext.irBuiltIns))
val id = tw.getLabelFor<DbArray>("@\"array;1;{$elementType}\"") {
tw.writeArrays(id, "ARRAY", elementType.javaResult.id, elementType.kotlinResult.id, 1, elementType.javaResult.id, elementType.kotlinResult.id)