hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 10:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update class/method names in the module

Browse Source
This commit is contained in:
luchua-bc
2021-01-06 16:49:35 +00:00
parent 5690bf49f4
commit f13b8814f5
2 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/src/experimental/Security/CWE/CWE-312/CleartextStorageSharedPrefs.ql
View File

@@ -83,11 +83,11 @@ private class EncryptedSharedPrefFlowConfig extends DataFlow4::Configuration {
}
override predicate isSource(DataFlow4::Node src) {
src.asExpr().(MethodAccess).getMethod() instanceof SharedPreferences::CreateEncryptedPrefsMethod
src.asExpr().(MethodAccess).getMethod() instanceof SharedPreferences::CreateEncryptedMethod
}
override predicate isSink(DataFlow4::Node sink) {
sink.asExpr().getType() instanceof SharedPreferences::TypePrefs
sink.asExpr().getType() instanceof SharedPreferences::TypeBase
}
}

20
java/ql/src/semmle/code/java/frameworks/android/SharedPreferences.qll
View File

@@ -5,21 +5,19 @@ import java
/** Definitions related to `android.content.SharedPreferences`. */
module SharedPreferences {
/** The interface `android.content.SharedPreferences` */
class TypePrefs extends Interface {
TypePrefs() { hasQualifiedName("android.content", "SharedPreferences") }
class TypeBase extends Interface {
TypeBase() { hasQualifiedName("android.content", "SharedPreferences") }
}
/** The class `androidx.security.crypto.EncryptedSharedPreferences`, which implements `SharedPreferences` with encryption support. */
class TypeEncryptedPrefs extends Class {
TypeEncryptedPrefs() {
hasQualifiedName("androidx.security.crypto", "EncryptedSharedPreferences")
}
class TypeEncrypted extends Class {
TypeEncrypted() { hasQualifiedName("androidx.security.crypto", "EncryptedSharedPreferences") }
}
/** The create method of `androidx.security.crypto.EncryptedSharedPreferences` */
class CreateEncryptedPrefsMethod extends Method {
CreateEncryptedPrefsMethod() {
getDeclaringType() instanceof TypeEncryptedPrefs and
class CreateEncryptedMethod extends Method {
CreateEncryptedMethod() {
getDeclaringType() instanceof TypeEncrypted and
hasName("create")
}
}
@@ -27,7 +25,7 @@ module SharedPreferences {
/** A getter method of `android.content.SharedPreferences`. */
class GetPreferenceMethod extends Method {
GetPreferenceMethod() {
getDeclaringType() instanceof TypePrefs and
getDeclaringType() instanceof TypeBase and
getName().matches("get%")
}
}
@@ -35,7 +33,7 @@ module SharedPreferences {
/** Returns `android.content.SharedPreferences.Editor` from the `edit` call of `android.content.SharedPreferences`. */
class GetEditorMethod extends Method {
GetEditorMethod() {
getDeclaringType() instanceof TypePrefs and
getDeclaringType() instanceof TypeBase and
hasName("edit") and
getReturnType() instanceof TypeEditor
}