From f12818a96de5798e15f5e7181bf86082c6f04889 Mon Sep 17 00:00:00 2001 From: Chris Smowton Date: Wed, 13 Nov 2024 15:15:09 +0000 Subject: [PATCH] Apply review comments --- .../src/main/kotlin/entities/Expression.kt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/java/kotlin-extractor2/src/main/kotlin/entities/Expression.kt b/java/kotlin-extractor2/src/main/kotlin/entities/Expression.kt index 1fcbd7966ab..6cf1287b218 100644 --- a/java/kotlin-extractor2/src/main/kotlin/entities/Expression.kt +++ b/java/kotlin-extractor2/src/main/kotlin/entities/Expression.kt @@ -2755,12 +2755,14 @@ fun KotlinFileExtractor.extractReferenceExpression( is KaSimpleVariableAccessCall -> { when (val varSymbol = resolvedCall.symbol) { is KaPropertySymbol -> { + // Note this could be a native Kotlin property, or a synthetic one for a Java object inferred + // from getters/setters. val (target, args) = when (val access = resolvedCall.simpleAccess) { is KaSimpleVariableAccess.Read -> Pair(varSymbol.getter, listOf()) is KaSimpleVariableAccess.Write -> Pair(varSymbol.setter, listOf(access.value)) } - val qualifier: KtExpression? = (ref.parent as? KtDotQualifiedExpression)?.receiverExpression + val qualifier: KtExpression? = (ref.parent as? KtQualifiedExpression)?.receiverExpression if (target == null) { TODO() @@ -2780,6 +2782,8 @@ fun KotlinFileExtractor.extractReferenceExpression( ) } else -> { + // TODO: field access, enum entries, others? + // but aren't property accesses? extractVariableAccess( useVariable(varSymbol), varSymbol.returnType,