hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10444 from hvitved/ruby/stmt-sequence-post-update

Browse Source 
Ruby: Add post-update nodes for compound arguments
This commit is contained in:
Tom Hvitved
2022-09-22 13:18:51 +02:00
committed by GitHub
parent 7d0bfe8f98 07f8b35af0
commit f0f4fe7286
13 changed files with 506 additions and 154 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/ql-libraries/dataflow/dataflow.md
View File

@@ -294,7 +294,10 @@ through an additional step targeting a `PostUpdateNode`).
It is recommended to introduce `PostUpdateNode`s for all `ArgumentNode`s (this
can be skipped for immutable arguments), and all field qualifiers for both
reads and stores.
reads and stores. Note also that in the case of compund arguments, such as
`b ? x : y`, it is recommented to have post-update nodes for `x` and `y` (and
not the compound argument itself), and let `[post update] x` have both `x`
and `b ? x : y` as pre-update nodes (and similarly for `[post update] y`).
Remember to define local flow for `PostUpdateNode`s as well in
`simpleLocalFlowStep`. In general out-going local flow from `PostUpdateNode`s