hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-19 13:48:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix failing test and make predicate private

Browse Source
This commit is contained in:
Andrew Eisenberg
2023-04-28 10:47:26 -07:00
parent c70398623a
commit f08b439afd
2 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
java/ql/lib/semmle/code/java/dataflow/ExternalFlowConfiguration.qll
View File

@@ -8,7 +8,7 @@ import ExternalFlowExtensions
/**
* Holds if the specified kind of source model is supported for the current query.
*/
extensible predicate supportedThreatModel(string kind);
private extensible predicate supportedThreatModel(string kind);
/**
* Holds if the specified kind of source model is containted within the specified group.
@@ -27,19 +27,9 @@ private string parentThreatModel(string kind) {
}
/**
* Finds all of the threat models that are children of the specified group.
* Holds if source models of the specified kind are
* supported for the current query.
*/
private string childThreatModel(string group) {
threatModelGrouping(result, group)
or exists(string child | childThreatModel(group) = child |
threatModelGrouping(result, child)
)
}
/**
* Holds if source models of the specified kind are
* supported for the current query.
*/
bindingset[kind]
predicate supportedSourceModel(string kind) {
// expansive threat model includes all kinds

2
java/ql/test/utils/modelgenerator/dataflow/CaptureSinkModels.expected
View File

@@ -1,3 +1,5 @@
| p;ParamFlow;true;writeChunked;(byte[],OutputStream);;Argument[0];sql;df-generated |
| p;ParamFlow;true;writeChunked;(char[],OutputStream);;Argument[0];sql;df-generated |
| p;PrivateFlowViaPublicInterface$SPI;true;openStream;();;Argument[this];create-file;df-generated |
| p;Sinks;true;copyFileToDirectory;(Path,Path,CopyOption[]);;Argument[0];read-file;df-generated |
| p;Sinks;true;copyFileToDirectory;(Path,Path,CopyOption[]);;Argument[1];create-file;df-generated |