From f04c8ccbc723ec333a99f3ab9d8166f6b977ace3 Mon Sep 17 00:00:00 2001 From: Owen Mansel-Chan Date: Thu, 18 Jun 2026 12:37:27 +0100 Subject: [PATCH] Use module already provided by BasicBlocks lib --- go/ql/lib/semmle/go/controlflow/BasicBlocks.qll | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/go/ql/lib/semmle/go/controlflow/BasicBlocks.qll b/go/ql/lib/semmle/go/controlflow/BasicBlocks.qll index d9908f260bb..9bb92bb7d46 100644 --- a/go/ql/lib/semmle/go/controlflow/BasicBlocks.qll +++ b/go/ql/lib/semmle/go/controlflow/BasicBlocks.qll @@ -42,22 +42,11 @@ private module Input implements BB::InputSig { predicate nodeIsPostDominanceExit(Node node) { node instanceof ExitNode } } -private module BbImpl = BB::Make; +module Cfg = BB::Make; -class BasicBlock = BbImpl::BasicBlock; +class BasicBlock = Cfg::BasicBlock; -class EntryBasicBlock = BbImpl::EntryBasicBlock; - -/** Provides a `CfgSig` view of Go's control-flow graph for use with the shared SSA library. */ -module Cfg implements BB::CfgSig { - class ControlFlowNode = BbImpl::ControlFlowNode; - - class BasicBlock = BbImpl::BasicBlock; - - class EntryBasicBlock = BbImpl::EntryBasicBlock; - - predicate dominatingEdge = BbImpl::dominatingEdge/2; -} +class EntryBasicBlock = Cfg::EntryBasicBlock; cached private predicate reachableBB(BasicBlock bb) {