Merge pull request #383 from esben-semmle/js/unused-eval-variable

Approved by xiemaisi

javascript/ql/src/Declarations/UnusedVariable.ql

@@ -163,6 +163,12 @@ predicate whitelisted(UnusedLocal v) {
     isEnumMember(vd) or
     // ignore ambient declarations - too noisy
     vd.isAmbient()
+  ) or
+  exists (DirectEval eval |
+    // eval nearby
+    eval.getEnclosingFunction() = v.getADeclaration().getEnclosingFunction() and
+    // ... but not on the RHS
+    not v.getAnAssignedExpr() = eval
   )
 }