hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Streamline definition of UserControlledRequestField.

Browse Source
This commit is contained in:
Max Schaefer
2020-01-16 10:41:38 +00:00
parent 39b28a4969
commit efc5f10f07
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ql/src/semmle/go/frameworks/HTTP.qll
View File

@@ -6,16 +6,12 @@ import go
private module StdlibHttp { private module StdlibHttp {
/** An access to an HTTP request field whose value may be controlled by an untrusted user. */ /** An access to an HTTP request field whose value may be controlled by an untrusted user. */
private class UserControlledRequestField extends UntrustedFlowSource::Range, DataFlow::ExprNode { private class UserControlledRequestField extends UntrustedFlowSource::Range, DataFlow::FieldReadNode {
override SelectorExpr expr;
UserControlledRequestField() { UserControlledRequestField() {
exists(Type req, Type baseType, string fieldName | exists(Type req, string fieldName |
req.hasQualifiedName("net/http", "Request") and req.hasQualifiedName("net/http", "Request") and
baseType = expr.getBase().getType() and this.getField() = req.getField(fieldName) |
fieldName = expr.getSelector().getName() and fieldName = "Body" or fieldName = "Form" or fieldName = "Header" or fieldName = "URL"
(baseType = req or baseType = req.getPointerType()) and
(fieldName = "Body" or fieldName = "Form" or fieldName = "Header" or fieldName = "URL")
) )
} }
} }