hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Don't pass taint through the format methods of Console

Browse Source
This commit is contained in:
Joe
2020-09-29 16:02:51 +01:00
parent eccfa5d26a
commit efc3a25237
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
View File

@@ -456,7 +456,8 @@ private predicate taintPreservingArgumentToMethod(Method method) {
method.getDeclaringType() instanceof TypeString and
method.hasName("join")
or
method instanceof StringFormatMethod
method instanceof StringFormatMethod and
not method.getDeclaringType().hasQualifiedName("java.io", "Console")
}
/**
@@ -649,7 +650,8 @@ private predicate argToQualifierStep(Expr tracked, Expr sink) {
*/
private predicate taintPreservingArgumentToQualifier(Method method) {
method instanceof StringFormatMethod and
not method.getDeclaringType() instanceof TypeString
not method.getDeclaringType() instanceof TypeString and
not method.getDeclaringType().hasQualifiedName("java.io", "Console")
}
/**