hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 00:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug in UnreachableBlocks

Browse Source
This commit is contained in:
Owen Mansel-Chan
2024-11-14 14:50:25 +00:00
parent c8c15a0899
commit efb34aea45
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/lib/semmle/code/java/controlflow/UnreachableBlocks.qll
View File

@@ -223,7 +223,7 @@ class UnreachableBasicBlock extends BasicBlock {
// Not accessible from the successful case
not constSwitchStmt.getMatchingCase().getBasicBlock().getABBSuccessor*() = failingCaseBlock and
// Blocks dominated by the failing case block are unreachable
constSwitchStmt.getAFailingCase().getBasicBlock().bbDominates(this)
failingCaseBlock.bbDominates(this)
)
}
}

1
java/ql/test/library-tests/unreachableblocks/UnreachableBlocks.expected
View File

@@ -3,7 +3,6 @@
| unreachableblocks/Unreachable.java:12:22:14:3 | { ... } |
| unreachableblocks/Unreachable.java:17:3:17:9 | case ... |
| unreachableblocks/Unreachable.java:19:3:19:9 | case ... |
| unreachableblocks/Unreachable.java:22:3:22:9 | case ... |
| unreachableblocks/Unreachable.java:24:3:24:9 | case ... |
| unreachableblocks/Unreachable.java:26:3:26:10 | case ... |
| unreachableblocks/Unreachable.java:27:3:27:10 | default |