hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 21:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove CallExpr.getQualifier() and its single, pointless, use.

Browse Source
This commit is contained in:
Max Schaefer
2020-01-16 10:40:24 +00:00
parent 8fc414b93f
commit ef964632be
2 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ql/src/semmle/go/Expr.qll
View File

@@ -444,13 +444,6 @@ class CallExpr extends CallOrConversionExpr {
) )
} }
/**
* Gets the qualifier of this call if it can be determined syntactically.
*
* For example, in the call `fmt.Println("hello")`, the qualifier is `fmt`.
*/
Expr getQualifier() { calls(result, _) }
/** Gets the `i`th argument expression of this call (0-based). */ /** Gets the `i`th argument expression of this call (0-based). */
Expr getArgument(int i) { Expr getArgument(int i) {
i >= 0 and i >= 0 and

6
ql/src/semmle/go/dataflow/internal/DataFlowPrivate.qll
View File

@@ -78,12 +78,6 @@ predicate jumpStep(Node n1, Node n2) {
) )
} }
/**
* Holds if `call` passes an implicit or explicit qualifier, i.e., a
* `this` parameter.
*/
predicate callHasQualifier(CallExpr call) { exists(call.getQualifier()) }
private newtype TContent = private newtype TContent =
TFieldContent(Field f) or TFieldContent(Field f) or
TCollectionContent() or TCollectionContent() or