From ef110e77ff3515c5d74ca17f3e6a644a73d04c34 Mon Sep 17 00:00:00 2001 From: Mathias Vorreiter Pedersen Date: Thu, 8 Dec 2022 17:53:54 +0000 Subject: [PATCH] C++: Remove an unnecessary predicate from the 'Indirection' class. --- .../cpp/ir/dataflow/internal/SsaInternalsCommon.qll | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll index 72c5adc9b61..5ce95b30342 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll @@ -176,12 +176,6 @@ abstract class Indirection extends Type { * from `opFrom` to `instrTo`. */ predicate isAdditionalConversionFlow(Operand opFrom, Instruction instrTo) { none() } - - /** - * Holds if writing the value `value` to an address with base `base` should - * be ignored. - */ - predicate ignoreSourceVariableBase(BaseSourceVariableInstruction base, Node0Impl value) { none() } } private class PointerOrReferenceTypeIndirection extends Indirection instanceof PointerOrReferenceType { @@ -231,10 +225,6 @@ predicate isAdditionalConversionFlow(Operand opFrom, Instruction instrTo) { any(Indirection ind).isAdditionalConversionFlow(opFrom, instrTo) } -predicate ignoreSourceVariableBase(BaseSourceVariableInstruction base, Node0Impl value) { - any(Indirection ind).ignoreSourceVariableBase(base, value) -} - newtype TBaseSourceVariable = // Each IR variable gets its own source variable TBaseIRVariable(IRVariable var) or