diff --git a/java/ql/lib/semmle/code/java/security/WebviewDubuggingEnabledQuery.qll b/java/ql/lib/semmle/code/java/security/WebviewDubuggingEnabledQuery.qll index 563590725e7..e9107ca10b4 100644 --- a/java/ql/lib/semmle/code/java/security/WebviewDubuggingEnabledQuery.qll +++ b/java/ql/lib/semmle/code/java/security/WebviewDubuggingEnabledQuery.qll @@ -22,7 +22,7 @@ private predicate isDebugCheck(Expr ex) { ) } -/** Configuration to find instances of `setWebContentDebuggingEnabled` called with `true` values. */ +/** A configuration to find instances of `setWebContentDebuggingEnabled` called with `true` values. */ class WebviewDebugEnabledConfig extends DataFlow::Configuration { WebviewDebugEnabledConfig() { this = "WebviewDebugEnabledConfig" } diff --git a/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.qhelp b/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.qhelp index e5290c42efc..04676caa378 100644 --- a/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.qhelp +++ b/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.qhelp @@ -7,7 +7,7 @@

The WebView.setWebContentsDebuggingEnabled method enables or disables the contents of any WebView in the application to be debugged.

Enabling debugging featues could allow for additional entry points or leaking sensitive information. -As such, debugging should only be anabled during development, and disabled during production builds. +As such, debugging should only be anabled during development, and disabled during production builds.

Ensure that debugging features are not enabled during production builds. diff --git a/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.ql b/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.ql index 8355ce76412..2e94852e211 100644 --- a/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.ql +++ b/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.ql @@ -12,7 +12,6 @@ import java import semmle.code.java.security.WebviewDubuggingEnabledQuery -import semmle.code.java.dataflow.DataFlow import DataFlow::PathGraph from WebviewDebugEnabledConfig conf, DataFlow::PathNode source, DataFlow::PathNode sink