hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-23 20:26:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Accept test changes.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-03-07 16:18:43 +00:00
parent a39a6ea648
commit eea02e1ac1
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/test/library-tests/dataflow/dataflow-tests/clang.cpp
View File

@@ -48,5 +48,5 @@ void following_pointers( // $ ast-def=sourceStruct1_ptr
int stackArray[2] = { source(), source() }; int stackArray[2] = { source(), source() };
stackArray[0] = source(); stackArray[0] = source();
sink(stackArray); // $ ast ir ir=49:7 ir=49:25 ir=49:35 ir=50:19 sink(stackArray); // $ ast ir ir=49:25 ir=49:35 ir=50:19
} }

24
cpp/ql/test/library-tests/dataflow/dataflow-tests/test.cpp
View File

@@ -423,17 +423,17 @@ void intPointerSourceCaller() {
intPointerSource(&local); intPointerSource(&local);
sink(local); // $ ast,ir=422:7 ast,ir=423:20 sink(local); // $ ast,ir=422:7 ast,ir=423:20
} }
// The IR results for this test _are_ equivalent to the AST ones.
// The IR annotation is just "ir" because the sink of the unitialized source at
// `433:7` (i.e., the declaration `int local[1];`) is value of `local`, but the sink
// of the source from `intPointerSource` value of `*local` (i.e., the indirection node
// of `local`). So unlike AST dataflow, each of these two sinks correspond to a unique
// source, and thus we don't need to attach a location annotation to it.
void intPointerSourceCaller2() { void intPointerSourceCaller2() {
int local[1]; int local[1];
intPointerSource(local); intPointerSource(local);
sink(local); // $ ast=433:7 ast=434:20 ir=433:7 ir=434:20 ir sink(local); // $ ast=434:20 ir SPURIOUS: ast=433:7
sink(*local); // $ ast=433:7 ast=434:20 ir=433:7 ir=434:20 sink(*local); // $ ast=434:20 ir SPURIOUS: ast=433:7
} }
void intArraySourceCaller() { void intArraySourceCaller() {
@@ -447,8 +447,8 @@ void intArraySourceCaller() {
void intArraySourceCaller2() { void intArraySourceCaller2() {
int local[2]; int local[2];
intArraySource(local, 2); intArraySource(local, 2);
sink(local); // $ ast=448:7 ast=449:18 ir=448:7 ir=449:18 ir sink(local); // $ ast=449:18 ir SPURIOUS: ast=448:7
sink(*local); // $ ast=448:7 ast=449:18 ir=448:7 ir=449:18 sink(*local); // $ ast=449:18 ir SPURIOUS: ast=448:7
} }
/////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////
@@ -518,7 +518,7 @@ void uncertain_definition() {
int clean = 0; int clean = 0;
stackArray[0] = source(); stackArray[0] = source();
stackArray[1] = clean; stackArray[1] = clean;
sink(stackArray[0]); // $ ast=519:19 ir=517:7 ir=519:19 SPURIOUS: ast=517:7 sink(stackArray[0]); // $ ast=519:19 ir SPURIOUS: ast=517:7
} }
void set_through_const_pointer(int x, const int **e) // $ ast-def=e ir-def=**e ir-def=*e void set_through_const_pointer(int x, const int **e) // $ ast-def=e ir-def=**e ir-def=*e
@@ -594,7 +594,7 @@ void test_indirect_flow_to_array() {
int* p = indirect_source(); int* p = indirect_source();
int* xs[2]; int* xs[2];
xs[0] = p; xs[0] = p;
sink(*xs[0]); // $ ir=594:12 MISSING: ast SPURIOUS: ir=595:8 sink(*xs[0]); // $ ir MISSING: ast
} }
void test_def_by_ref_followed_by_uncertain_write_array(int* p) { // $ ast-def=p ir-def=*p void test_def_by_ref_followed_by_uncertain_write_array(int* p) { // $ ast-def=p ir-def=*p