hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add start_tls_s() comment and use DataFlow::MethodCallNode instead

Browse Source
This commit is contained in:
jorgectf
2021-09-07 19:00:14 +02:00
parent 1bc16fb31e
commit ee98c0c587
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/ql/src/experimental/semmle/python/frameworks/LDAP.qll
View File

@@ -116,9 +116,9 @@ private module LDAP {
(
// ldap_connection.start_tls_s()
// see https://www.python-ldap.org/en/python-ldap-3.3.0/reference/ldap.html#ldap.LDAPObject.start_tls_s
exists(DataFlow::AttrRead startTLS |
exists(DataFlow::MethodCallNode startTLS |
startTLS.getObject().getALocalSource() = initialize and
startTLS.getAttributeName() = "start_tls_s"
startTLS.getMethodName() = "start_tls_s"
)
or
// ldap_connection.set_option(ldap.OPT_X_TLS_%s, True)
@@ -221,8 +221,10 @@ private module LDAP {
.flowsTo([serverCall.getArg(2), serverCall.getArgByName("use_ssl")])
)
or
exists(DataFlow::AttrRead startTLS |
startTLS.getAttributeName().matches("%start_tls%") and
// ldap_connection.start_tls_s()
// see https://www.python-ldap.org/en/python-ldap-3.3.0/reference/ldap.html#ldap.LDAPObject.start_tls_s
exists(DataFlow::MethodCallNode startTLS |
startTLS.getMethodName() = "start_tls_s" and
startTLS.getObject().getALocalSource() = this
)
}