From ed5960e0156cc44bc7436d64cb551bf95df4a673 Mon Sep 17 00:00:00 2001 From: Mathias Vorreiter Pedersen Date: Thu, 14 Oct 2021 10:48:54 +0100 Subject: [PATCH] QL: Respond to PR reviews. --- ql/src/queries/style/SuperfluousExists.ql | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/ql/src/queries/style/SuperfluousExists.ql b/ql/src/queries/style/SuperfluousExists.ql index 40a6c4054fd..84380330fa8 100644 --- a/ql/src/queries/style/SuperfluousExists.ql +++ b/ql/src/queries/style/SuperfluousExists.ql @@ -51,8 +51,6 @@ predicate exprImpliesExists(ValueNumber vn, Expr e) { or exprImpliesExists(vn, e.(AsExpr).getInnerExpr()) or - exprImpliesExists(vn, e.(Range).getAnEndpoint()) - or exists(ExprAggregate agg | agg = e and agg.getKind().matches(["strict%", "unique"]) and @@ -71,9 +69,8 @@ predicate formulaImpliesExists(ValueNumber vn, Formula f) { or exprImpliesExists(vn, f.(ComparisonFormula).getAnOperand()) or - exists(IfFormula ifFormula | ifFormula = f | - exprImpliesExists(vn, ifFormula.getCondition()) - or + exists(IfFormula ifFormula | + ifFormula = f and formulaImpliesExists(vn, ifFormula.getThenPart()) and formulaImpliesExists(vn, ifFormula.getElsePart()) )