hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

don't have a MembershipTestBarrierGuard in Configuration.qll

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-06-04 16:13:49 +02:00
parent b7a3c4a3d6
commit ed4e1bbbdf
2 changed files with 7 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
View File

@@ -1814,19 +1814,3 @@ class VarAccessBarrier extends DataFlow::Node {
)
}
}
/**
* A check of the form `whitelist.includes(x)` or equivalent, which sanitizes `x` in its "then" branch.
*
* Can be added to `isBarrierGuard` in a data-flow configuration to block flow through such checks.
*/
class MembershipTestBarrierGuard extends BarrierGuardNode {
MembershipCandidate candidate;
MembershipTestBarrierGuard() { this = candidate.getTest() }
override predicate blocks(boolean outcome, Expr e) {
candidate = e.flow() and
candidate.getTestPolarity() = outcome
}
}

9
javascript/ql/src/semmle/javascript/security/dataflow/TaintedPathCustomizations.qll
View File

@@ -373,9 +373,14 @@ module TaintedPath {
/**
* A check of the form `whitelist.includes(x)` or equivalent, which sanitizes `x` in its "then" branch.
*/
class MembershipTestBarrierGuard extends BarrierGuardNode, DataFlow::MembershipTestBarrierGuard {
class MembershipTestBarrierGuard extends BarrierGuardNode {
MembershipCandidate candidate;
MembershipTestBarrierGuard() { this = candidate.getTest() }
override predicate blocks(boolean outcome, Expr e) {
DataFlow::MembershipTestBarrierGuard.super.blocks(outcome, e)
candidate = e.flow() and
candidate.getTestPolarity() = outcome
}
}