From ed284353efc05accd349c9bcf7af243b89697554 Mon Sep 17 00:00:00 2001 From: Anders Schack-Mulligen Date: Mon, 10 Feb 2025 09:52:21 +0100 Subject: [PATCH] Java: Bugfix for qualifier-of-qualifier update in hasExplicitQualifierUpdate. --- java/ql/lib/semmle/code/java/dataflow/SSA.qll | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/java/ql/lib/semmle/code/java/dataflow/SSA.qll b/java/ql/lib/semmle/code/java/dataflow/SSA.qll index 66be73a4c01..3576b710487 100644 --- a/java/ql/lib/semmle/code/java/dataflow/SSA.qll +++ b/java/ql/lib/semmle/code/java/dataflow/SSA.qll @@ -228,9 +228,10 @@ class SsaImplicitUpdate extends SsaUpdate { } private predicate hasExplicitQualifierUpdate() { - exists(SsaExplicitUpdate qdef, BasicBlock bb, int i | + exists(SsaUpdate qdef, BasicBlock bb, int i | qdef.definesAt(this.getSourceVariable().getQualifier(), bb, i) and - this.definesAt(_, bb, i) + this.definesAt(_, bb, i) and + not qdef instanceof SsaUncertainImplicitUpdate ) }