hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-23 15:55:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Fix java/jvm-exit false positives for local nested classes in test methods

Browse Source
This commit is contained in:
Napalys Klicius
2025-08-21 14:12:54 +00:00
parent 41a78a0c3d
commit eb6e9b8fe6
3 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToSystemExit.ql
View File

@@ -63,7 +63,15 @@ class SourceMethodNotMainOrTest extends Method {
this.fromSource() and
not this instanceof MainMethod and
not this instanceof LikelyTestMethod and
not this.getEnclosingCallable() instanceof LikelyTestMethod
not (
this.getEnclosingCallable*() instanceof LikelyTestMethod
or
this.getDeclaringType()
.getEnclosingType*()
.(LocalClassOrInterface)
.getLocalTypeDeclStmt()
.getEnclosingCallable() instanceof LikelyTestMethod
)
}
}

4
java/ql/test/query-tests/CallsToSystemExit/CallsToSystemExit.expected
View File

@@ -4,7 +4,3 @@
| ExampleRuntimeHalt.java:21:17:21:44 | halt(...) | Avoid calls to Runtime.halt() as this prevents runtime cleanup and makes code harder to reuse. |
| ExampleSystemExit.java:22:17:22:30 | exit(...) | Avoid calls to System.exit() as this prevents runtime cleanup and makes code harder to reuse. |
| ExampleSystemExit.java:25:17:25:30 | exit(...) | Avoid calls to System.exit() as this prevents runtime cleanup and makes code harder to reuse. |
| LocalClassInTestMethod.java:7:25:7:38 | exit(...) | Avoid calls to System.exit() as this prevents runtime cleanup and makes code harder to reuse. |
| LocalClassInTestMethod.java:8:25:8:52 | halt(...) | Avoid calls to Runtime.halt() as this prevents runtime cleanup and makes code harder to reuse. |
| LocalClassInTestMethod.java:20:21:20:34 | exit(...) | Avoid calls to System.exit() as this prevents runtime cleanup and makes code harder to reuse. |
| LocalClassInTestMethod.java:21:21:21:48 | halt(...) | Avoid calls to Runtime.halt() as this prevents runtime cleanup and makes code harder to reuse. |

8
java/ql/test/query-tests/CallsToSystemExit/LocalClassInTestMethod.java
View File

@@ -4,8 +4,8 @@ public class LocalClassInTestMethod {
void func() {
class NestedLocalClass {
void nestedMethod() {
System.exit(4); // $ SPURIOUS: Alert
Runtime.getRuntime().halt(5); // $ SPURIOUS: Alert
System.exit(4);
Runtime.getRuntime().halt(5);
}
}
}
@@ -17,8 +17,8 @@ public class LocalClassInTestMethod {
class OuterLocalClass {
class NestedLocalClass {
void nestedMethod() {
System.exit(4); // $ SPURIOUS: Alert
Runtime.getRuntime().halt(5); // $ SPURIOUS: Alert
System.exit(4);
Runtime.getRuntime().halt(5);
}
}
}