Remove type check from the barrier predicate

2025-12-24 04:36:35 +01:00 · 2022-09-20 14:48:21 +01:00
parent ed8ec89497
commit eb3655da1c
1 changed files with 0 additions and 2 deletions
--- a/java/ql/lib/semmle/code/java/security/WebviewDubuggingEnabledQuery.qll
+++ b/java/ql/lib/semmle/code/java/security/WebviewDubuggingEnabledQuery.qll
@@ -34,8 +34,6 @@ class WebviewDebugEnabledConfig extends DataFlow::Configuration {
  }

  override predicate isBarrier(DataFlow::Node node) {
-    not node.getType() instanceof BooleanType
-    or
    exists(Guard debug | isDebugCheck(debug) and debug.controls(node.asExpr().getBasicBlock(), _))
    or
    node.getEnclosingCallable().getDeclaringType() instanceof NonSecurityTestClass