hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Performance experiment - add getFunctionFIle for better join order

Browse Source
This commit is contained in:
Joe Farebrother
2025-09-08 09:43:22 +01:00
parent 71dec0b23e
commit eb246f6f71
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
python/ql/src/Functions/SignatureOverriddenMethod.ql
View File

@@ -202,6 +202,9 @@ predicate callMatchesSignature(Function func, Call call) {
)
}
pragma[nomagic]
private File getFunctionFile(Function f) { result = f.getLocation().getFile() }
/** Gets a call which matches the signature of `base`, but not of overridden `sub`. */
Call getASignatureMismatchWitness(Function base, Function sub) {
callViableForEitherOverride(base, sub, result) and
@@ -224,17 +227,17 @@ Call chooseASignatureMismatchWitnessInFile(Function base, Function sub, File fil
Call chooseASignatureMismatchWitness(Function base, Function sub) {
exists(getASignatureMismatchWitness(base, sub)) and
(
result = chooseASignatureMismatchWitnessInFile(base, sub, base.getLocation().getFile())
result = chooseASignatureMismatchWitnessInFile(base, sub, getFunctionFile(base))
or
not exists(Call c |
c = getASignatureMismatchWitness(base, sub) and
c.getLocation().getFile() = base.getLocation().getFile()
) and
result = chooseASignatureMismatchWitnessInFile(base, sub, sub.getLocation().getFile())
result = chooseASignatureMismatchWitnessInFile(base, sub, getFunctionFile(sub))
or
not exists(Call c |
c = getASignatureMismatchWitness(base, sub) and
c.getLocation().getFile() = [base, sub].getLocation().getFile()
c.getLocation().getFile() = getFunctionFile([base, sub])
) and
result =
min(Call c |