From bd8a8d00aa5b3cbdfc01b82b084af823a5b20165 Mon Sep 17 00:00:00 2001 From: Ian Lynagh Date: Thu, 23 Jun 2022 16:44:06 +0100 Subject: [PATCH] Kotlin: Make some more methods private --- .../kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt | 4 ++-- .../kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt | 6 +++--- .../src/main/kotlin/utils/AutoCloseableUse.kt | 2 +- java/kotlin-extractor/src/main/kotlin/utils/Logger.kt | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt b/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt index 2c693bb3dd5..d9ac0be4183 100644 --- a/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt +++ b/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt @@ -41,7 +41,7 @@ open class KotlinFileExtractor( globalExtensionState: KotlinExtractorGlobalState ): KotlinUsesExtractor(logger, tw, dependencyCollector, externalClassExtractor, primitiveTypeMapping, pluginContext, globalExtensionState) { - inline fun with(kind: String, element: IrElement, f: () -> T): T { + private inline fun with(kind: String, element: IrElement, f: () -> T): T { val name = when (element) { is IrFile -> element.name is IrDeclarationWithName -> element.name.asString() @@ -2186,7 +2186,7 @@ open class KotlinFileExtractor( } } - fun getStatementOriginOperator(origin: IrStatementOrigin?) = when (origin) { + private fun getStatementOriginOperator(origin: IrStatementOrigin?) = when (origin) { IrStatementOrigin.PLUSEQ -> "plus" IrStatementOrigin.MINUSEQ -> "minus" IrStatementOrigin.MULTEQ -> "times" diff --git a/java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt b/java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt index f96dc65d48d..9f16261e7e6 100644 --- a/java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt +++ b/java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt @@ -190,7 +190,7 @@ open class KotlinUsesExtractor( } // The Kotlin compiler internal representation of Outer.Inner.InnerInner.someFunction.LocalClass is LocalClass. This function returns [A, B, C, D, E, F, G, H, I, J]. - fun orderTypeArgsLeftToRight(c: IrClass, argsIncludingOuterClasses: List?): List? { + private fun orderTypeArgsLeftToRight(c: IrClass, argsIncludingOuterClasses: List?): List? { if(argsIncludingOuterClasses.isNullOrEmpty()) return argsIncludingOuterClasses val ret = ArrayList() @@ -237,7 +237,7 @@ open class KotlinUsesExtractor( return UseClassInstanceResult(classTypeResult, extractClass) } - fun isArray(t: IrSimpleType) = t.isBoxedArray || t.isPrimitiveArray() + private fun isArray(t: IrSimpleType) = t.isBoxedArray || t.isPrimitiveArray() fun extractClassLaterIfExternal(c: IrClass) { if (isExternalDeclaration(c)) { @@ -1427,7 +1427,7 @@ open class KotlinUsesExtractor( return t } - fun eraseTypeParameter(t: IrTypeParameter) = + private fun eraseTypeParameter(t: IrTypeParameter) = erase(t.superTypes[0]) /** diff --git a/java/kotlin-extractor/src/main/kotlin/utils/AutoCloseableUse.kt b/java/kotlin-extractor/src/main/kotlin/utils/AutoCloseableUse.kt index fe68f308893..dad820ab6ee 100644 --- a/java/kotlin-extractor/src/main/kotlin/utils/AutoCloseableUse.kt +++ b/java/kotlin-extractor/src/main/kotlin/utils/AutoCloseableUse.kt @@ -40,4 +40,4 @@ fun AutoCloseable?.closeFinallyAC(cause: Throwable?) = when { } catch (closeException: Throwable) { cause.addSuppressed(closeException) } -} \ No newline at end of file +} diff --git a/java/kotlin-extractor/src/main/kotlin/utils/Logger.kt b/java/kotlin-extractor/src/main/kotlin/utils/Logger.kt index 1349380cbc4..1d83036e8e2 100644 --- a/java/kotlin-extractor/src/main/kotlin/utils/Logger.kt +++ b/java/kotlin-extractor/src/main/kotlin/utils/Logger.kt @@ -240,7 +240,7 @@ open class Logger(val loggerBase: LoggerBase, open val tw: TrapWriter) { loggerBase.info(tw, msg) } - fun warn(msg: String, extraInfo: String?) { + private fun warn(msg: String, extraInfo: String?) { loggerBase.warn(tw, msg, extraInfo) } fun warn(msg: String, exn: Throwable) { @@ -250,7 +250,7 @@ open class Logger(val loggerBase: LoggerBase, open val tw: TrapWriter) { warn(msg, null) } - fun error(msg: String, extraInfo: String?) { + private fun error(msg: String, extraInfo: String?) { loggerBase.error(tw, msg, extraInfo) } fun error(msg: String) {