hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
This commit is contained in:
Mathias Vorreiter Pedersen
2023-08-04 11:10:12 +02:00
committed by GitHub
parent 981f67531c
commit eb19052a7d
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shared/dataflow/change-notes/2023-08-02-dataflow-isSink.md
View File

@@ -1,4 +1,4 @@
---
category: feature
---
* The `StateConfigSig` signature now supports an `isSink/1` predicate that does not specify the `FlowState` for which the given node is a sink. Instead, any `FlowState` is considered a valid `FlowState` for the sink.
* The `StateConfigSig` signature now supports a unary `isSink` predicate that does not specify the `FlowState` for which the given node is a sink. Instead, any `FlowState` is considered a valid `FlowState` for such a sink.

2
shared/dataflow/codeql/dataflow/DataFlow.qll
View File

@@ -114,7 +114,7 @@ module Configs<DataFlowParameter Lang> {
predicate isSink(Node sink, FlowState state);
/**
* Holds if `sink` is a relevant data flow sink.
* Holds if `sink` is a relevant data flow sink for any state.
*/
default predicate isSink(Node sink) { none() }

4
shared/dataflow/codeql/dataflow/DataFlowImpl.qll
View File

@@ -4069,7 +4069,7 @@ module MakeImpl<DataFlowParameter Lang> {
NodeEx node, FlowState state, TRevSummaryCtx1 sc1, TRevSummaryCtx2 sc2,
TRevSummaryCtx3 sc3, PartialAccessPath ap
) {
sinkNodeWithState(node, state) and
revSinkNode(node, state) and
sc1 = TRevSummaryCtx1None() and
sc2 = TRevSummaryCtx2None() and
sc3 = TRevSummaryCtx3None() and
@@ -4287,7 +4287,7 @@ module MakeImpl<DataFlowParameter Lang> {
}
predicate isSink() {
sinkNodeWithState(node, state) and
revSinkNode(node, state) and
sc1 = TRevSummaryCtx1None() and
sc2 = TRevSummaryCtx2None() and
sc3 = TRevSummaryCtx3None() and