Use code-quality-selectors in C# suite

2026-04-25 08:45:14 +02:00 · 2025-04-29 16:02:46 +02:00
parent e3a6681182
commit ea9b95790b
15 changed files with 18 additions and 17 deletions
--- a/Abuse/FormatInvalid.ql
+++ b/Abuse/FormatInvalid.ql
@@ -8,6 +8,7 @@
 * @id cs/invalid-string-formatting
 * @tags reliability
 *       maintainability
+ *       quality
 */

 import csharp
--- a/Abuse/NoDisposeCallOnLocalIDisposable.ql
+++ b/Abuse/NoDisposeCallOnLocalIDisposable.ql
@@ -8,6 +8,7 @@
 * @id cs/local-not-disposed
 * @tags efficiency
 *       maintainability
+ *       quality
 *       external/cwe/cwe-404
 *       external/cwe/cwe-459
 *       external/cwe/cwe-460
--- a/Practices/Control-Flow/ConstantCondition.ql
+++ b/Practices/Control-Flow/ConstantCondition.ql
@@ -9,6 +9,7 @@
 * @id cs/constant-condition
 * @tags maintainability
 *       readability
+ *       quality
 *       external/cwe/cwe-835
 */

--- a/Code/DeadStoreOfLocal.ql
+++ b/Code/DeadStoreOfLocal.ql
@@ -6,6 +6,7 @@
 * @problem.severity warning
 * @id cs/useless-assignment-to-local
 * @tags maintainability
+ *       quality
 *       external/cwe/cwe-563
 * @precision very-high
 */
--- a/Bugs/Collections/ContainerLengthCmpOffByOne.ql
+++ b/Bugs/Collections/ContainerLengthCmpOffByOne.ql
@@ -9,6 +9,7 @@
 * @tags reliability
 *       correctness
 *       logic
+ *       quality
 *      external/cwe/cwe-193
 */

--- a/Bugs/Collections/ContainerSizeCmpZero.ql
+++ b/Bugs/Collections/ContainerSizeCmpZero.ql
@@ -8,6 +8,7 @@
 * @tags reliability
 *       correctness
 *       logic
+ *       quality
 */

 import csharp
--- a/Bugs/DangerousNonShortCircuitLogic.ql
+++ b/Bugs/DangerousNonShortCircuitLogic.ql
@@ -9,6 +9,7 @@
 * @tags reliability
 *       correctness
 *       logic
+ *       quality
 *       external/cwe/cwe-480
 *       external/cwe/cwe-691
 */
--- a/Bugs/EqualityCheckOnFloats.ql
+++ b/Bugs/EqualityCheckOnFloats.ql
@@ -9,6 +9,7 @@
 * @id cs/equality-on-floats
 * @tags reliability
 *       correctness
+ *       quality
 */

 import csharp
--- a/Bugs/ReferenceEqualsOnValueTypes.ql
+++ b/Bugs/ReferenceEqualsOnValueTypes.ql
@@ -7,6 +7,7 @@
 * @id cs/reference-equality-on-valuetypes
 * @tags reliability
 *       correctness
+ *       quality
 *       external/cwe/cwe-595
 */

--- a/Bugs/SelfAssignment.ql
+++ b/Bugs/SelfAssignment.ql
@@ -8,6 +8,7 @@
 * @tags reliability
 *       correctness
 *       logic
+ *       quality
 */

 import csharp
--- a/Bugs/UncheckedCastInEquals.ql
+++ b/Bugs/UncheckedCastInEquals.ql
@@ -7,6 +7,7 @@
 * @id cs/unchecked-cast-in-equals
 * @tags reliability
 *       maintainability
+ *       quality
 */

 import csharp
--- a/csharp/ql/src/Performance/UseTryGetValue.ql
+++ b/csharp/ql/src/Performance/UseTryGetValue.ql
@@ -6,7 +6,9 @@
 * @problem.severity recommendation
 * @precision high
 * @id cs/inefficient-containskey
- * @tags maintainability efficiency
+ * @tags maintainability
+ *       efficiency
+ *       quality
 */

 import csharp
--- a/code/DefaultToString.ql
+++ b/code/DefaultToString.ql
@@ -8,6 +8,7 @@
 * @id cs/call-to-object-tostring
 * @tags reliability
 *       maintainability
+ *       quality
 */

 import DefaultToStringQuery
--- a/code/IntGetHashCode.ql
+++ b/code/IntGetHashCode.ql
@@ -8,6 +8,7 @@
 * @id cs/useless-gethashcode-call
 * @tags readability
 *       useless-code
+ *       quality
 */

 import csharp
--- a/csharp/ql/src/codeql-suites/csharp-code-quality.qls
+++ b/csharp/ql/src/codeql-suites/csharp-code-quality.qls
@@ -1,17 +1,3 @@
 - queries: .
- include:
-    id:
-      - cs/index-out-of-bounds
-      - cs/test-for-negative-container-size
-      - cs/unchecked-cast-in-equals
-      - cs/reference-equality-on-valuetypes
-      - cs/self-assignment
-      - cs/inefficient-containskey
-      - cs/call-to-object-tostring
-      - cs/local-not-disposed
-      - cs/constant-condition
-      - cs/useless-gethashcode-call
-      - cs/non-short-circuit
-      - cs/useless-assignment-to-local
-      - cs/invalid-string-formatting
-      - cs/equality-on-floats
+- apply: code-quality-selectors.yml
+  from: codeql/suite-helpers