hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 11:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't bother hiding toString() and getLocation()

Browse Source
This commit is contained in:
Dave Bartolomeo
2022-03-15 14:47:26 -04:00
parent 72725875a5
commit ea9a5b782c
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/lib/experimental/semmle/code/cpp/semantic/SemanticExpr.qll
View File

@@ -12,9 +12,9 @@ private import SemanticExprSpecific::SemanticExprConfig as Specific
* the expression's opcode (`getOpcode()`).
*/
class SemExpr instanceof Specific::Expr {
final string toString() { result = Specific::exprToString(this) }
final string toString() { result = super.toString() }
final Specific::Location getLocation() { result = Specific::getExprLocation(this) }
final Specific::Location getLocation() { result = super.getLocation() }
Opcode getOpcode() { result instanceof Opcode::Unknown }

4
cpp/ql/lib/experimental/semmle/code/cpp/semantic/SemanticExprSpecific.qll
View File

@@ -13,10 +13,6 @@ module SemanticExprConfig {
class Expr = IR::Instruction;
string exprToString(Expr e) { result = e.toString() }
Location getExprLocation(Expr e) { result = e.getLocation() }
SemBasicBlock getExprBasicBlock(Expr e) { result = getSemanticBasicBlock(e.getBlock()) }
private predicate anyConstantExpr(Expr expr, SemType type, string value) {