mirror of
https://github.com/github/codeql.git
synced 2026-04-27 09:45:15 +02:00
Merge pull request #446 from geoffw0/minor-corrections
CPP: Minor corrections to examples
This commit is contained in:
@@ -1,10 +1,10 @@
|
||||
void* f() {
|
||||
block = malloc(BLOCK_SIZE);
|
||||
block = (MyBlock *)malloc(sizeof(MyBlock));
|
||||
if (block) { //correct: block is checked for nullness here
|
||||
block->id = NORMAL_BLOCK_ID;
|
||||
}
|
||||
//...
|
||||
/* make sure data-portion is null-terminated */
|
||||
block[BLOCK_SIZE - 1] = '\0'; //wrong: block not checked for nullness here
|
||||
block->data[BLOCK_SIZE - 1] = '\0'; //wrong: block not checked for nullness here
|
||||
return block;
|
||||
}
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
void f(char* string) {
|
||||
// wrong: allocates space for characters, put not zero terminator
|
||||
// wrong: allocates space for characters, but not zero terminator
|
||||
char* buf = malloc(strlen(string));
|
||||
strcpy(buf, string);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user