JS: Clarifying comment on commonStep

2026-04-27 09:45:15 +02:00 · 2025-06-11 10:24:21 +02:00
parent 2aa5fa17f7
commit e848aa747b
1 changed files with 2 additions and 0 deletions
--- a/javascript/ql/lib/semmle/javascript/internal/NameResolution.qll
+++ b/javascript/ql/lib/semmle/javascript/internal/NameResolution.qll
@@ -65,6 +65,8 @@ module NameResolution {

  /**
   * Holds if values/namespaces/types in `node1` can flow to values/namespaces/types in `node2`.
+   *
+   * May also include some type-specific steps in cases where this is harmless when tracking values.
   */
  private predicate commonStep(Node node1, Node node2) {
    // Import paths are part of the graph and has an incoming edge from the imported module, if found.