hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Updated doc string and removed redundant predicate.

Browse Source
This commit is contained in:
Napalys Klicius
2025-08-11 06:45:50 +00:00
parent e228aac61f
commit e82fe9d919
1 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
View File

@@ -565,12 +565,12 @@ predicate runtimeJumpStep(Node nodeFrom, Node nodeTo) {
* Holds if there is a jump step from `nodeFrom` to `nodeTo` through global variable field access. * Holds if there is a jump step from `nodeFrom` to `nodeTo` through global variable field access.
* This supports tracking nested object field access through global variables like `app.obj.foo`. * This supports tracking nested object field access through global variables like `app.obj.foo`.
*/ */
predicate globalVariableNestedFieldJumpStep(Node nodeFrom, Node nodeTo) { private predicate globalVariableNestedFieldJumpStep(Node nodeFrom, Node nodeTo) {
exists(ModuleVariableNode globalVar, AttrWrite write, AttrRead read | exists(ModuleVariableNode globalVar, AttrWrite write, AttrRead read |
// Match writes and reads on the same global variable attribute path // Match writes and reads on the same global variable attribute path
exists(string accessPath | exists(string accessPath |
globalVariableAttrPath(globalVar, accessPath, write.getObject()) and globalVariableAttrPathAtDepth(globalVar, accessPath, write.getObject(), _) and
globalVariableAttrPath(globalVar, accessPath, read.getObject()) globalVariableAttrPathAtDepth(globalVar, accessPath, read.getObject(), _)
) and ) and
write.getAttributeName() = read.getAttributeName() and write.getAttributeName() = read.getAttributeName() and
nodeFrom = write.getValue() and nodeFrom = write.getValue() and
@@ -580,25 +580,14 @@ predicate globalVariableNestedFieldJumpStep(Node nodeFrom, Node nodeTo) {
/** /**
* Maximum depth for global variable nested attribute access. * Maximum depth for global variable nested attribute access.
* Depth 0 = globalVar.foo, depth 1 = globalVar.foo.bar, depth 2 = globalVar.foo.bar.baz, etc. * Depth 1 = globalVar.foo, depth 2 = globalVar.foo.bar, depth 3 = globalVar.foo.bar.baz, etc.
*/ */
private int getMaxGlobalVariableDepth() { result = 2 } private int getMaxGlobalVariableDepth() { result = 2 }
/**
* Holds if `node` is an attribute access path starting from global variable `globalVar`.
* Supports configurable nesting depth via getMaxGlobalVariableDepth().
*/
predicate globalVariableAttrPath(ModuleVariableNode globalVar, string accessPath, Node node) {
exists(int depth |
globalVariableAttrPathAtDepth(globalVar, accessPath, node, depth) and
depth >= 0
)
}
/** /**
* Holds if `node` is an attribute access path starting from global variable `globalVar` at specific `depth`. * Holds if `node` is an attribute access path starting from global variable `globalVar` at specific `depth`.
*/ */
predicate globalVariableAttrPathAtDepth( private predicate globalVariableAttrPathAtDepth(
ModuleVariableNode globalVar, string accessPath, Node node, int depth ModuleVariableNode globalVar, string accessPath, Node node, int depth
) { ) {
// Base case: Direct global variable access (depth 0) // Base case: Direct global variable access (depth 0)