hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 12:46:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

support await in getSimpleAccessPath

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2022-03-30 21:54:25 +02:00
committed by Stephan Brandauer
parent 1db2117be4
commit e7de6cb4a7
1 changed files with 26 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointFeatures.qll
View File

@@ -459,24 +459,30 @@ private module SyntacticUtilities {
* Unknown cases and property names results in `?`.
*/
string getSimpleAccessPath(DataFlow::Node node) {
if node.asExpr() instanceof SuperAccess
then result = "super"
else
if node.asExpr() instanceof ThisAccess
then result = "this"
exists(Expr e | e = node.asExpr().getUnderlyingValue() |
if e instanceof SuperAccess
then result = "super"
else
if node.asExpr() instanceof VarAccess
then result = node.asExpr().(VarAccess).getName()
if e instanceof ThisAccess
then result = "this"
else
if node instanceof DataFlow::PropRead
then
result =
getSimpleAccessPath(node.(DataFlow::PropRead).getBase()) + "." +
getPropertyNameOrUnknown(node)
if e instanceof VarAccess
then result = e.(VarAccess).getName()
else
if node instanceof DataFlow::InvokeNode
then result = getSimpleAccessPath(node.(DataFlow::InvokeNode).getCalleeNode()) + "()"
else result = "?"
if e instanceof AwaitExpr
then result = getSimpleAccessPath(e.(AwaitExpr).getOperand().flow()) + ".then()"
else
if node instanceof DataFlow::PropRead
then
result =
getSimpleAccessPath(node.(DataFlow::PropRead).getBase()) + "." +
getPropertyNameOrUnknown(node)
else
if node instanceof DataFlow::InvokeNode
then
result = getSimpleAccessPath(node.(DataFlow::InvokeNode).getCalleeNode()) + "()"
else result = "?"
)
}
}
@@ -500,7 +506,11 @@ class CalleeAccessPathSimpleFromArgumentTraversal extends EndpointFeature,
override string getValue(DataFlow::Node endpoint) {
exists(DataFlow::InvokeNode invk |
result = SyntacticUtilities::getSimpleAccessPath(invk.getCalleeNode()) and
exists(string path |
path = SyntacticUtilities::getSimpleAccessPath(invk.getCalleeNode()) and
// collapse the unknown path to the empty string, as is convention for old features
if path = "?" then result = "" else result = path
) and
(
invk.getAnArgument() = endpoint or
SyntacticUtilities::getANestedInitializerValue(invk.getAnArgument()