hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix member-call- and C-cast-related FPs

Browse Source
This commit is contained in:
Nora Dimitrijević
2022-09-28 15:02:22 +02:00
parent cacf78838c
commit e7c1fadd94
2 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/test/query-tests/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation/test.cpp
View File

@@ -36,7 +36,7 @@ int test(int i, int j, int (*foo)(int), int (*bar)(int, int))
x.foo(i++), j++; // GOOD
(x.foo(i++), j++); // GOOD
(x.foo(i++), // GOOD [FALSE POSITIVE]
(x.foo(i++), // GOOD
j++);
(x.foo(i++),
j++); // BAD (?)
@@ -50,7 +50,7 @@ int test(int i, int j, int (*foo)(int), int (*bar)(int, int))
(void)(i++), j++; // GOOD
((void)(i++), j++); // GOOD
((void)(i++), // GOOD [FALSE POSITIVE]
((void)(i++), // GOOD
j++);
((void)(i++),
j++); // BAD (?)
@@ -73,9 +73,9 @@ int test(int i, int j, int (*foo)(int), int (*bar)(int, int))
BAR(i++,
j++); // GOOD: common pattern and unlikely to be misread.
using T = decltype(x.foo(i++), // GOOD [FALSE POSITIVE]
using T = decltype(x.foo(i++), // GOOD
j++);
(void)sizeof(x.foo(i++), // GOOD [FALSE POSITIVE]
(void)sizeof(x.foo(i++), // GOOD
j++);
// Comma in loops