hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

C#: Improved CIL instruction types to pass type consistency checks

Browse Source
This commit is contained in:
Calum Grant
2019-11-13 20:11:08 +00:00
parent 4f9b747a13
commit e752e45361
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
csharp/ql/src/semmle/code/cil/Instructions.qll
View File

@@ -167,7 +167,11 @@ module Opcodes {
class Neg extends UnaryExpr, @cil_neg { class Neg extends UnaryExpr, @cil_neg {
override string getOpcodeName() { result = "neg" } override string getOpcodeName() { result = "neg" }
override NumericType getType() { result = getOperand(0).getType() } override NumericType getType() {
result = getOperand().getType()
or
getOperand().getType() instanceof Enum and result instanceof IntType
}
} }
// Binary operations // Binary operations
@@ -1176,7 +1180,9 @@ module Opcodes {
class Localloc extends Expr, @cil_localloc { class Localloc extends Expr, @cil_localloc {
override string getOpcodeName() { result = "localloc" } override string getOpcodeName() { result = "localloc" }
override int getPopCount() { result = 1 } // ?? override int getPopCount() { result = 1 }
override PointerType getType() { result.getReferentType() instanceof ByteType }
} }
class Readonly extends Instruction, @cil_readonly { class Readonly extends Instruction, @cil_readonly {