hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Add sealed modifier to classes to fix dispose-pattern, remove explicit IDisposable implementations

Browse Source
This commit is contained in:
Tamas Vajk
2020-10-02 11:49:35 +02:00
parent 397be7e98f
commit e73ced2275
13 changed files with 23 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
csharp/extractor/Semmle.Util.Tests/CanonicalPathCache.cs
View File

@@ -6,7 +6,7 @@ using System;
namespace SemmleTests.Semmle.Util
{
public class CanonicalPathCacheTest : IDisposable
public sealed class CanonicalPathCacheTest : IDisposable
{
readonly ILogger Logger = new LoggerMock();
readonly string root;
@@ -24,9 +24,10 @@ namespace SemmleTests.Semmle.Util
root = Win32.IsWindows() ? @"X:\" : "/";
}
void IDisposable.Dispose()
public void Dispose()
{
File.Delete("abc");
Logger.Dispose();
}
[Fact]
@@ -172,7 +173,7 @@ namespace SemmleTests.Semmle.Util
CanonicalPathDots();
}
class LoggerMock : ILogger
sealed class LoggerMock : ILogger
{
public void Dispose() { }