Generalize the server definition in plugin registration

2026-05-01 19:55:15 +02:00 · 2022-11-15 16:27:14 +01:00
parent 563a56af9d
commit e5e3bb3705
1 changed files with 3 additions and 3 deletions
--- a/javascript/ql/lib/semmle/javascript/frameworks/Hapi.qll
+++ b/javascript/ql/lib/semmle/javascript/frameworks/Hapi.qll
@@ -20,11 +20,11 @@ module Hapi {
      // `register (server, options)`
      // `module.exports.plugin = {register, pkg};`
      this =
-        any(NodeModule m)
+        any(Module m)
            .getAnExportedValue("plugin")
-            .(DataFlow::ObjectLiteralNode)
+            .getALocalSource()
            .getAPropertySource("register")
-            .(DataFlow::FunctionNode)
+            .getAFunctionValue()
            .getParameter(0)
      or
      // `const after = function (server) {...};`