From e5d9f56a75fc3c98d805d9080a0c6d433e3e5485 Mon Sep 17 00:00:00 2001
From: Esben Sparre Andreasen <esbena@github.com>
Date: Mon, 31 Jan 2022 11:15:11 +0100
Subject: [PATCH] Remove some CodeInjection sinks

---
 .../dataflow/CodeInjectionCustomizations.qll  | 54 -------------------
 1 file changed, 54 deletions(-)

diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll
index 3bedce48cfa..7e04c482616 100644
--- a/javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll
+++ b/javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll
@@ -172,13 +172,6 @@ module CodeInjection {
           or
           callName = "setImmediate" and index = 0
         )
-        or
-        exists(DataFlow::GlobalVarRefNode wasm, string methodName |
-          wasm.getName() = "WebAssembly" and c = wasm.getAMemberCall(methodName)
-        |
-          methodName = "compile" or
-          methodName = "compileStreaming"
-        )
       |
         this = c.getArgument(index)
       )
@@ -196,9 +189,6 @@ module CodeInjection {
       exists(ReactNative::WebViewElement webView |
         // `injectedJavaScript` property of React Native `WebView`
         this = webView.getAPropertyWrite("injectedJavaScript").getRhs()
-        or
-        // argument to `injectJavascript` method of React Native `WebView`
-        this = webView.getAMethodCall("injectJavaScript").getArgument(0)
       )
     }
   }
@@ -253,16 +243,6 @@ module CodeInjection {
     }
   }
 
-  /**
-   * A value interpreted as as template by the `pug` library.
-   */
-  class PugTemplateSink extends TemplateSink {
-    PugTemplateSink() {
-      this =
-        DataFlow::moduleImport(["pug", "jade"]).getAMemberCall(["compile", "render"]).getArgument(0)
-    }
-  }
-
   /**
    * A value interpreted as a template by the `handlebars` library.
    */
@@ -281,40 +261,6 @@ module CodeInjection {
     }
   }
 
-  /**
-   * A value interpreted as a template by the `hogan.js` library.
-   */
-  class HoganTemplateSink extends TemplateSink {
-    HoganTemplateSink() {
-      this = DataFlow::moduleMember("hogan.js", "compile").getACall().getArgument(0)
-    }
-  }
-
-  /**
-   * A value interpreted as a template by the `eta` library.
-   */
-  class EtaTemplateSink extends TemplateSink {
-    EtaTemplateSink() { this = DataFlow::moduleMember("eta", "render").getACall().getArgument(0) }
-  }
-
-  /**
-   * A value interpreted as a template by the `squirrelly` library.
-   */
-  class SquirrelTemplateSink extends TemplateSink {
-    SquirrelTemplateSink() {
-      this = DataFlow::moduleMember("squirrelly", "render").getACall().getArgument(0)
-    }
-  }
-
-  /**
-   * A value interpreted as a template by the `whiskers` library.
-   */
-  class WhiskersTemplateSink extends TemplateSink {
-    WhiskersTemplateSink() {
-      this = DataFlow::moduleMember("whiskers", "render").getACall().getArgument(0)
-    }
-  }
-
   /**
    * A value interpreted as a template by the `dot` library.
    */