hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Improve alert message for py/iter-returns-non-iterator

Browse Source 
Fixes https://github.com/Semmle/ql/issues/1427
This commit is contained in:
Rasmus Wriedt Larsen
2019-10-16 15:57:18 +02:00
parent 6056b457e9
commit e487fd3648
2 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
python/ql/src/Functions/IterReturnsNonIterator.ql
View File

@@ -12,8 +12,6 @@
import python
FunctionObject iter_method(ClassObject t) { result = t.lookupAttribute("__iter__") }
cached
ClassObject return_type(FunctionObject f) {
exists(ControlFlowNode n, Return ret |
@@ -23,12 +21,12 @@ ClassObject return_type(FunctionObject f) {
)
}
from ClassObject t, FunctionObject iter
from ClassObject container, FunctionObject iter, ClassObject iterator
where
exists(ClassObject ret_t |
iter = iter_method(t) and
ret_t = return_type(iter) and
not ret_t.isIterator()
)
select iter, "The '__iter__' method of iterable class $@ does not return an iterator.", t,
t.getName()
iter = container.lookupAttribute("__iter__") and
iterator = return_type(iter) and
not iterator.isIterator()
select iterator,
"Class " + iterator.getName() +
" is returned as an iterator (by $@) but does not fully implement the iterator interface.",
iter, iter.getName()