hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 11:16:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: handle TODO

Browse Source 
although this is not actually tested,
so we may have to adjust once we use it.
But the _very_ generic implementation is modeled on the Ruby code.
This commit is contained in:
Rasmus Lerchedahl Petersen
2022-09-12 21:03:56 +02:00
parent 78d4dc3123
commit e3280c8a3e
1 changed files with 43 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
python/ql/lib/semmle/python/dataflow/new/FlowSummary.qll
View File

@@ -2,6 +2,8 @@
private import python
private import semmle.python.dataflow.new.DataFlow
private import semmle.python.frameworks.data.ModelsAsData
private import semmle.python.ApiGraphs
private import internal.FlowSummaryImpl as Impl
private import internal.DataFlowUtil
private import internal.DataFlowPrivate
@@ -67,32 +69,44 @@ abstract class SummarizedCallable extends LibraryCallable, Impl::Public::Summari
}
class RequiredSummaryComponentStack = Impl::Public::RequiredSummaryComponentStack;
//
// TODO: Implement this
//
// private class SummarizedCallableFromModel extends SummarizedCallable {
// string package;
// string type;
// string path;
// SummarizedCallableFromModel() {
// ModelOutput::relevantSummaryModel(package, type, path, _, _, _) and
// this = package + ";" + type + ";" + path
// }
// override Call getACall() {
// exists(API::MethodAccessNode base |
// ModelOutput::resolvedSummaryBase(package, type, path, base) and
// result = base.getCallNode().asExpr().getExpr()
// )
// }
// override predicate propagatesFlowExt(string input, string output, boolean preservesValue) {
// exists(string kind |
// ModelOutput::relevantSummaryModel(package, type, path, input, output, kind)
// |
// kind = "value" and
// preservesValue = true
// or
// kind = "taint" and
// preservesValue = false
// )
// }
// }
// This gives access to getNodeFromPath, which is not constrained to `CallNode`s
// as `resolvedSummaryBase` is.
private import semmle.python.frameworks.data.internal.ApiGraphModels as AGM
private class SummarizedCallableFromModel extends SummarizedCallable {
string package;
string type;
string path;
SummarizedCallableFromModel() {
ModelOutput::relevantSummaryModel(package, type, path, _, _, _) and
this = package + ";" + type + ";" + path
}
override CallNode getACall() {
exists(API::CallNode base |
ModelOutput::resolvedSummaryBase(package, type, path, base) and
result = base.asCfgNode()
)
}
override ArgumentNode getACallback() {
exists(API::Node base |
base = AGM::getNodeFromPath(package, type, path) and
result = base.getAValueReachableFromSource()
)
}
override predicate propagatesFlowExt(string input, string output, boolean preservesValue) {
exists(string kind |
ModelOutput::relevantSummaryModel(package, type, path, input, output, kind)
|
kind = "value" and
preservesValue = true
or
kind = "taint" and
preservesValue = false
)
}
}