hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 00:35:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Port InsufficientPasswordHash

Browse Source
This commit is contained in:
Asger F
2023-10-05 09:21:25 +02:00
parent fd98b2546d
commit e1fae3d16d
3 changed files with 25 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
javascript/ql/lib/semmle/javascript/security/dataflow/InsufficientPasswordHashQuery.qll
View File

@@ -19,7 +19,23 @@ import InsufficientPasswordHashCustomizations::InsufficientPasswordHash
* added either by extending the relevant class, or by subclassing this configuration itself,
* and amending the sources and sinks.
*/
class Configuration extends TaintTracking::Configuration {
module InsufficientPasswordHashConfig implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) { source instanceof Source }
predicate isSink(DataFlow::Node sink) { sink instanceof Sink }
predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }
}
/**
* Taint tracking for password hashing with insufficient computational effort.
*/
module InsufficientPasswordHashFlow = TaintTracking::Global<InsufficientPasswordHashConfig>;
/**
* DEPRECATED. Use the `InsufficientPasswordHashFlow` module instead.
*/
deprecated class Configuration extends TaintTracking::Configuration {
Configuration() { this = "InsufficientPasswordHash" }
override predicate isSource(DataFlow::Node source) { source instanceof Source }

6
javascript/ql/src/Security/CWE-916/InsufficientPasswordHash.ql
View File

@@ -12,9 +12,9 @@
import javascript
import semmle.javascript.security.dataflow.InsufficientPasswordHashQuery
import DataFlow::PathGraph
import InsufficientPasswordHashFlow::PathGraph
from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink
where cfg.hasFlowPath(source, sink)
from InsufficientPasswordHashFlow::PathNode source, InsufficientPasswordHashFlow::PathNode sink
where InsufficientPasswordHashFlow::flowPath(source, sink)
select sink.getNode(), source, sink, "Password from $@ is hashed insecurely.", source.getNode(),
source.getNode().(Source).describe()

18
javascript/ql/test/query-tests/Security/CWE-916/InsufficientPasswordHash.expected
View File

@@ -1,17 +1,9 @@
nodes
| tst.js:5:48:5:55 | password |
| tst.js:5:48:5:55 | password |
| tst.js:5:48:5:55 | password |
| tst.js:7:46:7:53 | password |
| tst.js:7:46:7:53 | password |
| tst.js:7:46:7:53 | password |
| tst.js:9:43:9:50 | password |
| tst.js:9:43:9:50 | password |
| tst.js:9:43:9:50 | password |
edges
| tst.js:5:48:5:55 | password | tst.js:5:48:5:55 | password |
| tst.js:7:46:7:53 | password | tst.js:7:46:7:53 | password |
| tst.js:9:43:9:50 | password | tst.js:9:43:9:50 | password |
nodes
| tst.js:5:48:5:55 | password | semmle.label | password |
| tst.js:7:46:7:53 | password | semmle.label | password |
| tst.js:9:43:9:50 | password | semmle.label | password |
subpaths
#select
| tst.js:5:48:5:55 | password | tst.js:5:48:5:55 | password | tst.js:5:48:5:55 | password | Password from $@ is hashed insecurely. | tst.js:5:48:5:55 | password | an access to password |
| tst.js:7:46:7:53 | password | tst.js:7:46:7:53 | password | tst.js:7:46:7:53 | password | Password from $@ is hashed insecurely. | tst.js:7:46:7:53 | password | an access to password |