hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: model Object.clone

Browse Source
This commit is contained in:
Arthur Baars
2020-07-09 14:50:29 +02:00
parent 6ef7288848
commit e183171fea
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
View File

@@ -292,6 +292,8 @@ private predicate qualifierToMethodStep(Expr tracked, MethodAccess sink) {
* Methods that return tainted data when called on tainted data.
*/
private predicate taintPreservingQualifierToMethod(Method m) {
m instanceof CloneMethod
or
m.getDeclaringType() instanceof TypeString and
(
m.getName() = "concat" or

6
java/ql/test/library-tests/dataflow/local-additional-taint/Test.java
View File

@@ -4,11 +4,11 @@ import org.apache.commons.codec.BinaryEncoder;
import org.apache.commons.codec.BinaryDecoder;
import org.apache.commons.codec.StringEncoder;
import org.apache.commons.codec.StringDecoder;
import java.util.Date;
class Test {
public static void taintSteps(
Date date,
Decoder decoder,
Encoder encoder,
StringEncoder stringEncoder,
@@ -29,5 +29,7 @@ class Test {
bytes1 = binEncoder.encode(bytes2);
bytes1 = binDecoder.decode(bytes2);
Object clone = date.clone();
}
}

1
java/ql/test/library-tests/dataflow/local-additional-taint/localAdditionalTaintStep.expected
View File

@@ -41,3 +41,4 @@
| Test.java:28:34:28:40 | string2 | Test.java:28:13:28:41 | encode(...) |
| Test.java:30:30:30:35 | bytes2 | Test.java:30:12:30:36 | encode(...) |
| Test.java:31:30:31:35 | bytes2 | Test.java:31:12:31:36 | decode(...) |
| Test.java:33:18:33:21 | date | Test.java:33:18:33:29 | clone(...) |