hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: @precision high for tainted-format-string*

Browse Source 
I think these queries have excellent results on lgtm.com. Many of the
results come from projects that use `sprintf` like it's a templating
engine, trusting that values from `argv` or `getenv` contain the correct
number of `%s`. I think we want to flag that.

The structure of the change note is modeled after 91af51cf46.
This commit is contained in:
Jonas Jensen
2020-06-16 16:47:33 +02:00
parent e5e373cff2
commit e0ba23d2c7
3 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
change-notes/1.25/analysis-cpp.md
View File

@@ -13,6 +13,8 @@ The following changes in version 1.25 affect C/C++ analysis in all applications.
| **Query** | **Expected impact** | **Change** | | **Query** | **Expected impact** | **Change** |
|----------------------------|------------------------|------------------------------------------------------------------| |----------------------------|------------------------|------------------------------------------------------------------|
| Uncontrolled format string (`cpp/tainted-format-string`) | | This query is now displayed by default on LGTM. |
| Uncontrolled format string (through global variable) (`cpp/tainted-format-string-through-global`) | | This query is now displayed by default on LGTM. |
## Changes to libraries ## Changes to libraries

2
cpp/ql/src/Security/CWE/CWE-134/UncontrolledFormatString.ql
View File

@@ -5,7 +5,7 @@
* or data representation problems. * or data representation problems.
* @kind path-problem * @kind path-problem
* @problem.severity warning * @problem.severity warning
* @precision medium * @precision high
* @id cpp/tainted-format-string * @id cpp/tainted-format-string
* @tags reliability * @tags reliability
* security * security

2
cpp/ql/src/Security/CWE/CWE-134/UncontrolledFormatStringThroughGlobalVar.ql
View File

@@ -5,7 +5,7 @@
* or data representation problems. * or data representation problems.
* @kind path-problem * @kind path-problem
* @problem.severity warning * @problem.severity warning
* @precision medium * @precision high
* @id cpp/tainted-format-string-through-global * @id cpp/tainted-format-string-through-global
* @tags reliability * @tags reliability
* security * security