hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-04 13:15:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Give Snprintf a proper interface.

Browse Source
This commit is contained in:
Geoffrey White
2020-11-06 09:28:52 +00:00
parent c9f846e0d2
commit e065466180
2 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cpp/ql/src/semmle/code/cpp/models/implementations/Printf.qll
View File

@@ -119,11 +119,10 @@ private class Sprintf extends FormattingFunction {
}
/**
* The standard functions `snprintf` and `swprintf`, and their
* Microsoft and glib variants.
* Implements `Snprintf`.
*/
private class Snprintf extends FormattingFunction {
Snprintf() {
private class SnprintfImpl extends Snprintf {
SnprintfImpl() {
this instanceof TopLevelFunction and
(
hasGlobalOrStdName("snprintf") or // C99 defines snprintf
@@ -180,12 +179,7 @@ private class Snprintf extends FormattingFunction {
)
}
/**
* Holds if this function returns the length of the formatted string
* that would have been output, regardless of the amount of space
* in the buffer.
*/
predicate returnsFullFormatLength() {
override predicate returnsFullFormatLength() {
(
hasGlobalOrStdName("snprintf") or
hasGlobalName("g_snprintf") or

13
cpp/ql/src/semmle/code/cpp/models/interfaces/FormattingFunction.qll
View File

@@ -165,3 +165,16 @@ abstract class FormattingFunction extends ArrayFunction, TaintFunction {
)
}
}
/**
* The standard functions `snprintf` and `swprintf`, and their
* Microsoft and glib variants.
*/
abstract class Snprintf extends FormattingFunction {
/**
* Holds if this function returns the length of the formatted string
* that would have been output, regardless of the amount of space
* in the buffer.
*/
predicate returnsFullFormatLength() { none() }
}