From e06294bcb4ccfbc0783c47a1a8c9f0f84578f2da Mon Sep 17 00:00:00 2001
From: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Date: Tue, 7 Apr 2026 11:11:04 +0100
Subject: [PATCH] Shared: Respond to review comments.

---
 .../codeql/dataflow/internal/DataFlowImplStage1.qll | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll
index e9c92844fb7..b7a45a67b56 100644
--- a/shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll
+++ b/shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll
@@ -86,15 +86,13 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {
     bindingset[p, kind]
     predicate parameterFlowThroughAllowed(ParamNd p, ReturnKindExt kind);
 
+    predicate fwdFlow(Nd node);
+
     // begin StageSig
     class Ap;
 
     class ApNil extends Ap;
 
-    predicate fwdFlow(Nd node);
-
-    predicate fwdFlow(Nd node, Ap ap);
-
     predicate revFlow(Nd node);
 
     predicate revFlow(Nd node, Ap ap);
@@ -1297,11 +1295,6 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {
 
       predicate fwdFlow(Nd node) { Stage1::fwdFlow(node) }
 
-      predicate fwdFlow(Nd node, Ap ap) {
-        Stage1::fwdFlow(node) and
-        exists(ap)
-      }
-
       predicate revFlow(NodeEx node, Ap ap) { Stage1::revFlow(node) and exists(ap) }
 
       predicate toNormalSinkNode = toNormalSinkNodeEx/1;
@@ -1408,8 +1401,6 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {
 
       predicate fwdFlow(Nd node) { Stage1::fwdFlow(node.getNodeEx()) }
 
-      predicate fwdFlow(Nd node, Ap ap) { Stage1::fwdFlow(node.getNodeEx()) and exists(ap) }
-
       predicate revFlow(Nd node) { Stage1::revFlow(node.getNodeEx()) }
 
       predicate revFlow(Nd node, Ap ap) { Stage1::revFlow(node.getNodeEx()) and exists(ap) }