hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 00:35:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Adjust subclass finder to no ESSA nodes

Browse Source 
But the new test results looks very strange indeed!
This commit is contained in:
Rasmus Wriedt Larsen
2023-12-08 16:39:55 +01:00
parent 60b784a919
commit e050f2e998
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/ql/lib/semmle/python/frameworks/internal/SubclassFinder.qll
View File

@@ -199,11 +199,7 @@ module NotExposed {
relevantClass = newOrExistingModeling(spec).getASubclass*() and
ImportResolution::module_export(mod, relevantName, def) and
value = relevantClass.getAValueReachableFromSource().asCfgNode() and
(
value = def.asVar().getDefinition().(AssignmentDefinition).getValue()
or
value = def.asCfgNode()
)
value = def.asCfgNode()
// value could be a ClassExpr if a new class is defined, or a Name if defining an alias
) and
(

6
python/ql/test/experimental/library-tests/FindSubclass/Find.expected
View File

@@ -1,3 +1,7 @@
| Django.Views.View~Subclass | find_subclass_test | Member[ViewAliasInExcept] |
| Django.Views.View~Subclass | find_subclass_test | Member[ViewAliasInTry] |
| Django.Views.View~Subclass | find_subclass_test | Member[__name__] |
| Django.Views.View~Subclass | find_subclass_test | Member[__package__] |
| Django.Views.View~Subclass | find_subclass_test | Member[clash2] |
| Django.Views.View~Subclass | find_subclass_test | Member[clash3] |
| Django.Views.View~Subclass | find_subclass_test | Member[clash] |
@@ -9,6 +13,8 @@
| flask.View~Subclass | find_subclass_test | Member[ViewAlias] |
| flask.View~Subclass | find_subclass_test | Member[ViewAlias_no_use] |
| flask.View~Subclass | find_subclass_test | Member[View] |
| flask.View~Subclass | find_subclass_test | Member[__name__] |
| flask.View~Subclass | find_subclass_test | Member[__package__] |
| flask.View~Subclass | find_subclass_test | Member[clash2] |
| flask.View~Subclass | find_subclass_test | Member[clash3] |
| flask.View~Subclass | find_subclass_test | Member[clash] |