hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: generalize to include default imports

Browse Source
This commit is contained in:
Asger F
2019-02-13 18:03:57 +00:00
parent d532815efe
commit dfe3f254de
7 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll
View File

@@ -39,7 +39,7 @@ module DataFlow {
not exists(SsaExplicitDefinition ssa | p = ssa.getDef())
} or
TDestructuredModuleImportNode(ImportDeclaration decl) {
decl.getASpecifier() instanceof NamedImportSpecifier
exists(decl.getASpecifier().getImportedName())
}
/**
@@ -346,10 +346,7 @@ module DataFlow {
}
/**
* A node referring to the module imported at a named ES2015 import declaration.
*
* Default imports and namespace imports do not fall into this category, as the
* SSA definition of the local variable is used as the source of the module instead.
* A node referring to the module imported at a named or default ES2015 import declaration.
*/
private class DestructuredModuleImportNode extends Node, TDestructuredModuleImportNode {
ImportDeclaration imprt;
@@ -687,13 +684,14 @@ module DataFlow {
/**
* A named import specifier seen as a property read on the imported module.
*/
private class NamedImportSpecifierAsPropRead extends PropRead {
private class ImportSpecifierAsPropRead extends PropRead {
ImportDeclaration imprt;
NamedImportSpecifier spec;
ImportSpecifier spec;
NamedImportSpecifierAsPropRead() {
ImportSpecifierAsPropRead() {
spec = imprt.getASpecifier() and
exists(spec.getImportedName()) and
exists(SsaExplicitDefinition ssa |
ssa.getDef() = spec and
this = TSsaDefNode(ssa)